Skip to content
This repository was archived by the owner on May 19, 2025. It is now read-only.

please consider including tests/ dir in pypi release #50

Closed
sandrotosi opened this issue Apr 23, 2016 · 4 comments
Closed

please consider including tests/ dir in pypi release #50

sandrotosi opened this issue Apr 23, 2016 · 4 comments

Comments

@sandrotosi
Copy link

Hello,
i noticed the github repo has a tests/ directory, while the tarball on pypi doesnt: could you consider adding it? it would be helpful for distributions to verify everything is working as expected and generally it's a nice practice to be able to run tests of a third-party modules.

thanks for considering,
Sandro

@mvexel
Copy link
Owner

mvexel commented Apr 6, 2018

Could you supply the necessary changes to setup.py and / or setup.cfg?

@sandrotosi
Copy link
Author

thanks!! do you mind adding also the examples/ directory? i still dont see tests/ in 0.6.0 (as released on PyPI) so hopefully the next release :)

@mvexel mvexel reopened this May 14, 2018
@mvexel mvexel closed this as completed in 97ca504 Aug 30, 2018
@mvexel
Copy link
Owner

mvexel commented Aug 30, 2018

finally! :)

@sandrotosi
Copy link
Author

thanks a lot! it looks like tests/__pycache__/test_api.cpython-27-PYTEST.pyc sneaked into the PyPI tarball release. it's no big deal at all, but you may want to release only source code the next time :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants