Skip to content

TypeScript implementation? #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sublimator opened this issue Mar 8, 2017 · 3 comments
Closed

TypeScript implementation? #559

sublimator opened this issue Mar 8, 2017 · 3 comments

Comments

@sublimator
Copy link
Member

What are peoples thoughts/feelings about converting the lib/ implementation to TypeScript? (I did exactly this while in the process of creating headers/declarations for #547 The results are here: https://github.com/sublimator/MQTT.js/tree/typescript)

I'm not super invested, though it occurs to me it may be easier to maintain one TypeScript codebase rather than JS + TypeScript headers. I figured I'd bring it up now before the branch gets too stale.

@mcollina ?
@adamvr ?
@radekg ?
@mcollina
Copy link
Member

mcollina commented Mar 8, 2017

I'm definitely -1 on the idea. I'm ok in supporting TypeScript, not in using it directly.

@ghost
Copy link

ghost commented Mar 8, 2017 •
edited by ghost
Loading

It's easier to support Javascript only, because TypeScript is just a superset of it. 😂

@sublimator
Copy link
Member Author

sublimator commented Mar 8, 2017 via email

@mcollina mcollina closed this as completed Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcollina @sublimator