Skip to content

Re-enable Go race detector #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q3k opened this issue Sep 8, 2021 · 4 comments
Closed

Re-enable Go race detector #76

q3k opened this issue Sep 8, 2021 · 4 comments
Labels
enhancement New feature or request refactor Tech debt cleanup research-and-design

Comments

@q3k
Copy link
Contributor

q3k commented Sep 8, 2021

We currently test without the Go race detector enabled. That's because the Go race detector depends on cgo, and our cgo/musl integration currently doesn't work (as cgo calls our gcc wrapper from a nested directory within execroot, but our gcc wrapper / sysroot makes assumptions that we always run from the execroot).

There might also also be some other complications like the race detector not working with musl - that will have to be investigated.

We could also just enable the race detector for host go_test targets, and nothing else.

@q3k q3k added enhancement New feature or request research-and-design refactor Tech debt cleanup labels Sep 8, 2021
@leoluk
Copy link
Member

leoluk commented Sep 8, 2021

@q3k
Copy link
Contributor Author

q3k commented Jul 13, 2022

We should at least re-enable it when running host tests, which shouldn't depend on the above two bugs being fixed.

@q3k
Copy link
Contributor Author

q3k commented Oct 31, 2024

Letting someone else deal with this. This will either require waiting for the Go race detector to work without CGO, or getting CGO to work.

There's some early work in https://review.monogon.dev/c/monogon/+/1833 ; good luck.

@fionera
Copy link
Contributor

fionera commented Feb 24, 2025

This is done.

@fionera fionera closed this as completed Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Tech debt cleanup research-and-design
Projects
None yet
Development

No branches or pull requests

3 participants