Linter fixes

Author: SimonBaeumer

.githooks/pre-commit

@@ -163,7 +163,7 @@ run_shellcheck() {
 
 start_shellcheck() {
   files_1=$(find scripts -type f -name "*.sh")
-  files_2=$(find scripts/dev/contexts -type f)
+  files_2=$(find scripts/dev/contexts -type f | grep -v private-context)
   files_3=$(find scripts/funcs -type f)
   files_4=$(find public/architectures -type f -name "*.sh")
   files=$(echo -e "$files_1\n$files_2\n$files_3\n$files_4")

pipeline_test.py

@@ -75,21 +75,36 @@ def test_operator_build_configuration_defaults():
         (["a", "b", "c"], None, ["d"], ValueError),
         ([], ["a"], ["b"], ValueError),
         (["a", "b", "c"], None, None, {"a", "b", "c"}),
-
         # Given an include, it should only return include images
         (["cli", "ops-manager", "appdb-daily", "init-appdb"], ["cli"], [], {"cli"}),
-
         # Given no include nor excludes it should return all images
-        (["cli", "ops-manager", "appdb-daily", "init-appdb"], [], [], {'init-appdb', 'appdb-daily', 'ops-manager', 'cli'}),
-
+        (
+            ["cli", "ops-manager", "appdb-daily", "init-appdb"],
+            [],
+            [],
+            {"init-appdb", "appdb-daily", "ops-manager", "cli"},
+        ),
         # Given an exclude, it should return all images except the excluded ones
-        (["cli", "ops-manager", "appdb-daily", "init-appdb"], [], ['init-appdb', 'appdb-daily'], {'ops-manager', 'cli'}),
-
+        (
+            ["cli", "ops-manager", "appdb-daily", "init-appdb"],
+            [],
+            ["init-appdb", "appdb-daily"],
+            {"ops-manager", "cli"},
+        ),
         # Given an include and a different exclude, it should return all images except the exclusions
-        (["cli", "ops-manager", "appdb-daily", "init-appdb"], ['appdb-daily'], ['init-appdb'], {'appdb-daily', 'cli', 'ops-manager'}),
-
+        (
+            ["cli", "ops-manager", "appdb-daily", "init-appdb"],
+            ["appdb-daily"],
+            ["init-appdb"],
+            {"appdb-daily", "cli", "ops-manager"},
+        ),
         # Given multiple includes and a different exclude, it should return all images except the exclusions
-        (["cli", "ops-manager", "appdb-daily", "init-appdb"], ['cli', 'appdb-daily'], ['init-appdb'], {'appdb-daily', 'cli', 'ops-manager'}),
+        (
+            ["cli", "ops-manager", "appdb-daily", "init-appdb"],
+            ["cli", "appdb-daily"],
+            ["init-appdb"],
+            {"appdb-daily", "cli", "ops-manager"},
+        ),
     ],
 )
 def test_calculate_images_to_build(test_case):

scripts/dev/install.sh

@@ -18,7 +18,6 @@ elif [ "$(uname)" = "Linux" ] ; then # Ubuntu only
 
   kops_version="$(curl -s https://api.github.com/repos/kubernetes/kops/releases/latest | grep tag_name | cut -d '"' -f 4)"
   curl -Lo kops "https://github.com/kubernetes/kops/releases/download/${kops_version}/kops-linux-amd64"
-  echo "hi"
   chmod +x kops
   mv kops "${GOBIN}"  || true