-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix corrupted figures in plot_background_freesurfer_mne #9007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think this has to do with a change related to whether the camera's focal point is at 0, 0, 0 (new behavior) or center of the bounding box of all objects in the scene (old behavior). @GuillaumeFavelier I think we should make sure that there is some option like |
Agreed, the behaviour of the focal point should be clarified and maybe even tested (to avoid this out of focus brain regression) ? |
A simple test would be to compute the center of mass based on non-background-color pixels. Do you want to try @GuillaumeFavelier ? |
bounds are given by VTK's |
I'm on it |
Just found another corrupted 3D plot: https://mne.tools/dev/auto_tutorials/evoked/plot_20_visualize_evoked.html#d-field-maps |
Several plots in
tutorials/source-modeling/plot_background_freesurfer_mne.py
are messed up (inverted, misaligned, or corrupted). See if you can fix them. Check with @larsoner or @GuillaumeFavelier before you start; some of them might be due to 3D viz bugs that aren't fixed yet.The text was updated successfully, but these errors were encountered: