-
Notifications
You must be signed in to change notification settings - Fork 79
Publishing a new major version (dropping support for older php versions, finishing TODOs) #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for opening the issue on php-language-server. I am ok with removing support for 7.0 and 7.1 but would look for feedback since Felix might have some idea of how many PHP devs are not updating regularly. |
There's still no feedback on felixfbecker/php-language-server#790 after 5 months, and with the release of php 8.0.0, there's a better idea of what applications would use for a new major release of tolerant-php-parser |
@roblourens - some questions before starting work on this
|
Sorry for the slow response. I will not have time in the near future to do the development work myself, but if you would like to work on this, I would set up a branch as you suggest, review changes, help out however needed. |
void
andobject
and nullable types from php 7.2. https://www.php.net/supported-versions.php still officially supports 7.2 for security patches (some third parties backport patches on a best effort basis, e.g. when packaged for Linux):void
, which means supporting multiple phpunit versions is inconvenient.Related to #328 - it's possible to work around and run php 8.0 in Travis so keeping php 7.0 support is possible
I'm only familiar with a few of the packages depending on this https://github.com/microsoft/tolerant-php-parser/network/dependents?dependent_type=PACKAGE&package_id=UGFja2FnZS01NDI3MTMyOTI%3D
It may be useful to support new token types in 8.0, but staying on 0.0.x indefinitely might add tech debt.
The text was updated successfully, but these errors were encountered: