Skip to content

Come up with better consistent names for getStart/getEndPosition #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roblourens opened this issue Aug 7, 2017 · 2 comments
Closed
Labels

Comments

@roblourens
Copy link
Member

#156 (comment)

@TysonAndre
Copy link
Contributor

TysonAndre commented Sep 23, 2017

In the meantime, could you add an alias to either of the classes? (e.g. add getStartPosition() to Node, keeping the existing getStart() method and maybe marking it as deprecated).

Adding a new alias should be backwards compatible, and lets users get an offset without doing an instanceof check

@TysonAndre
Copy link
Contributor

The Node and Token methods were changed in #349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants