Skip to content

Clarify status of local variables in documentSymbol #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Yanpas opened this issue Feb 26, 2018 · 3 comments
Closed

Clarify status of local variables in documentSymbol #414

Yanpas opened this issue Feb 26, 2018 · 3 comments
Labels
discussion *out-of-scope Posted issue is not in scope of VS Code

Comments

@Yanpas
Copy link

Yanpas commented Feb 26, 2018

Both C# and C++ language servers filter local variables, but some (Python, JS) do not. documentSymbol is used to build outline of a document and local variables are barely useful. I think it should be mentioned in the standard how to treat them. Personally I vote for filtering

@dbaeumer
Copy link
Member

dbaeumer commented Mar 7, 2018

I am personally against stating this in the specification. I have no problems with having an implementation guide line page where we mention good practices but there might be use cases we don't see where it makes sense to include them.

@tboby
Copy link

tboby commented Jan 13, 2019

For an alternative perspective, the scripting language I maintain a language server for doesn't have the concept of local variables. It's data oriented and barely has control flow.

For this language, even the SymbolKind enum is an overly restrictive and arbitrary.

If you have a language without functions, variables, interfaces, classes or even arrays: what on earth would I do with a protocol requirement to exclude local variables?

@dbaeumer dbaeumer added the *out-of-scope Posted issue is not in scope of VS Code label Oct 31, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 31, 2019

We closed this issue because we don't plan to address it in the foreseeable future. You can find more detailed information about our decision-making process here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

3 participants