Skip to content

Completions are low-quality for UMD modules without typings #20565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amcasey opened this issue Dec 8, 2017 · 2 comments
Open

Completions are low-quality for UMD modules without typings #20565

amcasey opened this issue Dec 8, 2017 · 2 comments
Labels
Domain: JavaScript The issue relates to JavaScript specifically Needs Proposal This issue needs a plan that clarifies the finer details of how it could be implemented. Suggestion An idea for TypeScript

Comments

@amcasey
Copy link
Member

amcasey commented Dec 8, 2017

For example, reference oidc-client.js from the corresponding npm package, instantiate an Oidc.UserManager, and dot into the resulting object.

Expected: properties of Oidc.UserManager are offered
Actual: identifiers appearing in file are offered (i.e. min-bar experience).

@amcasey
Copy link
Member Author

amcasey commented Dec 8, 2017

FYI @brockallen.

@brockallen
Copy link

brockallen commented Dec 8, 2017

There are two builds of that library -- one that assumes you're using a package manager (in ~/lib), and another that doesn't (in ~/dist). The samples I used to show to @amcasey were not (so the ones in ~/dist).

@mhegazy mhegazy added Salsa Suggestion An idea for TypeScript Needs Proposal This issue needs a plan that clarifies the finer details of how it could be implemented. labels Jan 10, 2018
@weswigham weswigham added Domain: JavaScript The issue relates to JavaScript specifically and removed Domain: JavaScript The issue relates to JavaScript specifically Salsa labels Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Domain: JavaScript The issue relates to JavaScript specifically Needs Proposal This issue needs a plan that clarifies the finer details of how it could be implemented. Suggestion An idea for TypeScript
Projects
None yet
Development

No branches or pull requests

4 participants