Skip to content

Removing JSDoc comments from d.ts files #20441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pankleks opened this issue Dec 4, 2017 · 3 comments
Closed

Removing JSDoc comments from d.ts files #20441

pankleks opened this issue Dec 4, 2017 · 3 comments

Comments

@pankleks
Copy link

pankleks commented Dec 4, 2017

I'm building my library with option to remove comments. At the same time I generate d.ts files for library.
Expectation is to remove comments from produced js files, and not from d.ts.

js is production file - I don't wan't comments there, d.ts is development - so JSDoc comment should not be removed even if remove comments flag is specified.
@mhegazy
Copy link
Contributor

mhegazy commented Dec 4, 2017

Duplicate of #14619

@mhegazy mhegazy marked this as a duplicate of #14619 Dec 4, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Dec 4, 2017

I think we should just change the behavior of --removeComments to exclude declarations.. I am sure some one will hate this behavior though :).

@pankleks
Copy link
Author

pankleks commented Dec 4, 2017

I'm sure of that too ... :) 2 parameters?:)
closing in favor of #14619

@pankleks pankleks closed this as completed Dec 4, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhegazy @pankleks