Skip to content

Better comment emit on tokens #17689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
26 of 39 tasks
weswigham opened this issue Aug 9, 2017 · 1 comment
Closed
26 of 39 tasks

Better comment emit on tokens #17689

weswigham opened this issue Aug 9, 2017 · 1 comment
Labels
Domain: Comment Emit The issue relates to the emission of comments when compiling Meta-Issue An issue about the team, or the direction of TypeScript

Comments

@weswigham
Copy link
Member

weswigham commented Aug 9, 2017

Carrying on from the work initiated in #17557, we should improve our retention of comments where possible. We should check that we retain comments inside:

More? I welcome examples of places where we do not preserve comments on tokens in the middle of nodes, as that is the general vein of comment preservation we're looking at with these.

@RyanCavanaugh
Copy link
Member

This looks as done as it needs to be; we can take others on a case by case basis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Domain: Comment Emit The issue relates to the emission of comments when compiling Meta-Issue An issue about the team, or the direction of TypeScript
Projects
None yet
Development

No branches or pull requests

3 participants