Merge pull request #1124 from Microsoft/completionListAugmentedType

If we are comparing left hand side for is position of type node, it is f...

Author: sheetalkamat

src/compiler/checker.ts

@@ -8467,7 +8467,7 @@ module ts {
                 // above them to find the lowest container
                 case SyntaxKind.Identifier:
                     // If the identifier is the RHS of a qualified name, then it's a type iff its parent is.
-                    if (node.parent.kind === SyntaxKind.QualifiedName) {
+                    if (node.parent.kind === SyntaxKind.QualifiedName && (<QualifiedName>node.parent).right === node) {
                         node = node.parent;
                     }
                     // fall through

tests/baselines/reference/cloduleAndTypeParameters.types

@@ -2,7 +2,7 @@
 class Foo<T extends Foo.Bar> {
 >Foo : Foo<T>
 >T : T
->Foo : Foo<T>
+>Foo : unknown
 >Bar : Foo.Bar
 
   constructor() {

tests/baselines/reference/exportAssignClassAndModule.types

@@ -5,7 +5,7 @@ import Foo = require('exportAssignClassAndModule_0');
 
 var z: Foo.Bar;
 >z : Foo.Bar
->Foo : Foo
+>Foo : unknown
 >Bar : Foo.Bar
 
 var zz: Foo;
@@ -23,7 +23,7 @@ class Foo {
 
     x: Foo.Bar;
 >x : Foo.Bar
->Foo : Foo
+>Foo : unknown
 >Bar : Foo.Bar
 }
 module Foo {

tests/baselines/reference/exportEqualNamespaces.types

@@ -11,7 +11,7 @@ interface server {
 >server : server
 
     (): server.Server;
->server : server
+>server : unknown
 >Server : server.Server
 
     startTime: Date;

tests/baselines/reference/importAliasIdentifiers.types

@@ -61,12 +61,12 @@ import clolias = clodule;
 
 var p: clolias.Point;
 >p : alias.Point
->clolias : clodule
+>clolias : unknown
 >Point : clolias.Point
 
 var p: clodule.Point;
 >p : alias.Point
->clodule : clodule
+>clodule : unknown
 >Point : clolias.Point
 
 var p: { x: number; y: number; };

tests/baselines/reference/privacyCheckExportAssignmentOnExportedGenericInterface1.types

@@ -13,7 +13,7 @@ interface Foo<T> {
 }
 var Foo: new () => Foo.A<Foo<string>>;
 >Foo : new () => Foo.A<Foo<string>>
->Foo : Foo<T>
+>Foo : unknown
 >A : Foo.A<T>
 >Foo : Foo<T>
 

tests/cases/fourslash/augmentedTypesModule6.ts

@@ -10,9 +10,7 @@
 
 goTo.marker('1');
 verify.completionListContains('I');
-
-// bug #837 
-verify.completionListContains('foo');
+verify.not.completionListContains('foo');
 edit.insert('I;');
 
 goTo.marker('2');

tests/cases/fourslash/completionInAugmentedClassModule.ts

@@ -0,0 +1,8 @@
+/// <reference path='fourslash.ts'/>
+
+////declare class m3f { foo(x: number): void }
+////module m3f { export interface I { foo(): void } }
+////var x: m3f./**/
+
+goTo.marker();
+verify.not.completionListContains("foo");