From c595fbc9181382e2238ce6c91cf42b253d1a1329 Mon Sep 17 00:00:00 2001
From: "andrii.zinkevych" <a.zinkevych@atwix.com>
Date: Fri, 5 Nov 2021 15:28:42 +0100
Subject: [PATCH 1/2] Added deprecated function PHP 8.1 to
 DiscouragedFunctionSniff

---
 .../Functions/DiscouragedFunctionSniff.php    |  7 ++++++
 .../Functions/DiscouragedFunctionUnitTest.inc | 22 +++++++++++++++++++
 .../Functions/DiscouragedFunctionUnitTest.php | 13 ++++++++++-
 3 files changed, 41 insertions(+), 1 deletion(-)

diff --git a/Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php b/Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php
index 4982f8cc..a3332c0c 100644
--- a/Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php
+++ b/Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php
@@ -238,5 +238,12 @@ class DiscouragedFunctionSniff extends ForbiddenFunctionsSniff
         '^fseek$' => 'Magento\Framework\Filesystem\DriverInterface::fileSeek()',
         '^feof$' => 'Magento\Framework\Filesystem\DriverInterface::endOfFile()',
         '^flock$' => 'Magento\Framework\Filesystem\DriverInterface::fileLock()',
+        '^date_sunrise$' => 'date_sun_info',
+        '^date_sunset$' => 'date_sun_info',
+        '^strptime$' => 'date_parse_from_format',
+        '^strftime$' => null,
+        '^gmstrftime$' => null,
+        '^(mhash|mhash_.*)$' => null,
+        '^odbc_result_all$' => null
     ];
 }
diff --git a/Magento2/Tests/Functions/DiscouragedFunctionUnitTest.inc b/Magento2/Tests/Functions/DiscouragedFunctionUnitTest.inc
index 0302ff56..7aaafaf1 100644
--- a/Magento2/Tests/Functions/DiscouragedFunctionUnitTest.inc
+++ b/Magento2/Tests/Functions/DiscouragedFunctionUnitTest.inc
@@ -482,3 +482,25 @@ fseek($file, 0);
 feof($fp);
 
 flock($fp, LOCK_EX);
+
+$test = date_sunrise(0);
+
+$test = date_sunset(0);
+
+$test = strptime('12.12.12 00:00:00', 'D, d M Y H:i:s');
+
+strftime('D, d M Y H:i:s');
+
+gmstrftime('D, d M Y H:i:s');
+
+$test = mhash(1000, 'test_value');
+
+$test = mhash_count();
+
+$test = mhash_get_block_size(1000);
+
+$test = mhash_get_hash_name(1000);
+
+$test = mhash_keygen_s2k(1000, 'password', 'abccdf' , 10);
+
+$test = odbc_result_all('test_value', 'test_value');
diff --git a/Magento2/Tests/Functions/DiscouragedFunctionUnitTest.php b/Magento2/Tests/Functions/DiscouragedFunctionUnitTest.php
index 2a30100e..dee3dd92 100644
--- a/Magento2/Tests/Functions/DiscouragedFunctionUnitTest.php
+++ b/Magento2/Tests/Functions/DiscouragedFunctionUnitTest.php
@@ -255,7 +255,18 @@ public function getWarningList()
             478 => 1,
             480 => 1,
             482 => 1,
-            484 => 1
+            484 => 1,
+            486 => 1,
+            488 => 1,
+            490 => 1,
+            492 => 1,
+            494 => 1,
+            496 => 1,
+            498 => 1,
+            500 => 1,
+            502 => 1,
+            504 => 1,
+            506 => 1
         ];
     }
 }

From ef8bd3fc91c5a75b1a7fcd3f936fcd8117b58f1f Mon Sep 17 00:00:00 2001
From: "andrii.zinkevych" <a.zinkevych@atwix.com>
Date: Sun, 7 Nov 2021 18:22:41 +0100
Subject: [PATCH 2/2] Fixed code by recommendation

---
 Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php b/Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php
index a3332c0c..13acffdc 100644
--- a/Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php
+++ b/Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php
@@ -241,9 +241,9 @@ class DiscouragedFunctionSniff extends ForbiddenFunctionsSniff
         '^date_sunrise$' => 'date_sun_info',
         '^date_sunset$' => 'date_sun_info',
         '^strptime$' => 'date_parse_from_format',
-        '^strftime$' => null,
-        '^gmstrftime$' => null,
-        '^(mhash|mhash_.*)$' => null,
+        '^strftime$' => 'IntlDateFormatter::format',
+        '^gmstrftime$' => 'IntlDateFormatter::format',
+        '^(mhash|mhash_.*)$' => 'hash_*',
         '^odbc_result_all$' => null
     ];
 }