-
Notifications
You must be signed in to change notification settings - Fork 160
Individual polyfill packages should be used instead of symfony/polyfill #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @stof. Thank you for your report. Join Magento Community Engineering Slack and ask your questions in #github channel. |
Based on the commit that introduced it (2ea3c39), the package that is needed is |
We can probably drop the polyfill requirement again, because support was dropped for PHP < 8.1 in 8d37ab7 |
in such case, the requirement is indeed useless (this is another benefit of requiring individual polyfills as it would have been clear that |
Currently, this package depends on
symfony/polyfill
instead of the individualsymfony/polyfill-*
packages.This package installing the whole mono-repo is discouraged as it installs much more stuff than necessary.
The Symfony team (which I'm a member of) recommends using the individual packages instead. If we were starting it today, we would not even publish the
symfony/polyfill
package on Packagist at all, keeping it a development-only mono-repo.Currently, this even triggers a weird behavior in Composer. See composer/composer#11641
The text was updated successfully, but these errors were encountered: