Skip to content

Commit 209959a

Browse files
committed
remove invitationUrl field from request body
1 parent d54b5b1 commit 209959a

File tree

4 files changed

+47
-31
lines changed

4 files changed

+47
-31
lines changed

server/api-service/lowcoder-server/src/main/java/org/lowcoder/api/authentication/AuthenticationController.java

-11
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import org.lowcoder.api.util.BusinessEventPublisher;
1414
import org.lowcoder.domain.authentication.FindAuthConfig;
1515
import org.lowcoder.domain.user.model.APIKey;
16-
import org.lowcoder.domain.user.service.EmailCommunicationService;
1716
import org.lowcoder.domain.user.service.UserService;
1817
import org.lowcoder.sdk.auth.AbstractAuthConfig;
1918
import org.lowcoder.sdk.util.CookieHelper;
@@ -36,7 +35,6 @@ public class AuthenticationController implements AuthenticationEndpoints
3635
private final CookieHelper cookieHelper;
3736
private final BusinessEventPublisher businessEventPublisher;
3837
private final UserService userService;
39-
private final EmailCommunicationService emailCommunicationService;
4038

4139
/**
4240
* login by email or phone with password; or register by email for now.
@@ -137,13 +135,4 @@ public Mono<ResponseView<?>> bindEmail(@RequestParam String email) {
137135
return sessionUserService.getVisitor().flatMap(user -> userService.bindEmail(user, email))
138136
.map(ResponseView::success);
139137
}
140-
141-
@Override
142-
public Mono<ResponseView<Boolean>> sendInvitationEmails(InviteEmailRequest req) {
143-
boolean isSuccess = emailCommunicationService.sendInvitationEmails(req.emails(),
144-
req.inviteLink(),
145-
"You have been invited to join our platform. Click here to accept the invitation: %s");
146-
147-
return Mono.just(ResponseView.success(isSuccess));
148-
}
149138
}

server/api-service/lowcoder-server/src/main/java/org/lowcoder/api/authentication/AuthenticationEndpoints.java

+14-20
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package org.lowcoder.api.authentication;
22

3-
import com.fasterxml.jackson.annotation.JsonView;
4-
import io.swagger.v3.oas.annotations.Operation;
3+
import java.util.List;
4+
55
import org.lowcoder.api.authentication.dto.APIKeyRequest;
66
import org.lowcoder.api.authentication.dto.AuthConfigRequest;
77
import org.lowcoder.api.framework.view.ResponseView;
@@ -13,11 +13,20 @@
1313
import org.lowcoder.sdk.auth.AbstractAuthConfig;
1414
import org.lowcoder.sdk.config.JsonViews;
1515
import org.lowcoder.sdk.constants.AuthSourceConstants;
16-
import org.springframework.web.bind.annotation.*;
16+
import org.springframework.web.bind.annotation.DeleteMapping;
17+
import org.springframework.web.bind.annotation.GetMapping;
18+
import org.springframework.web.bind.annotation.PathVariable;
19+
import org.springframework.web.bind.annotation.PostMapping;
20+
import org.springframework.web.bind.annotation.RequestBody;
21+
import org.springframework.web.bind.annotation.RequestMapping;
22+
import org.springframework.web.bind.annotation.RequestParam;
23+
import org.springframework.web.bind.annotation.RestController;
1724
import org.springframework.web.server.ServerWebExchange;
18-
import reactor.core.publisher.Mono;
1925

20-
import java.util.List;
26+
import com.fasterxml.jackson.annotation.JsonView;
27+
28+
import io.swagger.v3.oas.annotations.Operation;
29+
import reactor.core.publisher.Mono;
2130

2231
@RestController
2332
@RequestMapping(value = {NewUrl.CUSTOM_AUTH})
@@ -151,15 +160,6 @@ public Mono<ResponseView<Boolean>> linkAccountWithThirdParty(
151160
)
152161
@PostMapping("/email/bind")
153162
public Mono<ResponseView<?>> bindEmail(@RequestParam String email);
154-
155-
@Operation(
156-
tags = TAG_AUTHENTICATION,
157-
operationId = "sendInvitationEmails",
158-
summary = "Send invitation emails",
159-
description = "Send invitation emails to the specified addresses"
160-
)
161-
@PostMapping("/email/invite")
162-
public Mono<ResponseView<Boolean>> sendInvitationEmails(@RequestBody InviteEmailRequest req);
163163

164164
/**
165165
* @param loginId phone number or email for now.
@@ -168,11 +168,5 @@ public Mono<ResponseView<Boolean>> linkAccountWithThirdParty(
168168
*/
169169
public record FormLoginRequest(String loginId, String password, boolean register, String source, String authId) {
170170
}
171-
/**
172-
* @param emails email addresses to send the invitation to
173-
* @param inviteLink the link to be included in the email
174-
*/
175-
public record InviteEmailRequest(String[] emails, String inviteLink) {
176-
}
177171
}
178172

server/api-service/lowcoder-server/src/main/java/org/lowcoder/api/usermanagement/InvitationController.java

+17
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
import org.lowcoder.api.framework.view.ResponseView;
88
import org.lowcoder.api.home.SessionUserService;
99
import org.lowcoder.api.usermanagement.view.InvitationVO;
10+
import org.lowcoder.domain.user.service.EmailCommunicationService;
11+
import org.lowcoder.sdk.config.CommonConfig;
1012
import org.springframework.beans.factory.annotation.Autowired;
1113
import org.springframework.web.bind.annotation.PathVariable;
1214
import org.springframework.web.bind.annotation.RequestParam;
@@ -24,6 +26,12 @@ public class InvitationController implements InvitationEndpoints
2426
@Autowired
2527
private SessionUserService sessionUserService;
2628

29+
@Autowired
30+
private EmailCommunicationService emailCommunicationService;
31+
32+
@Autowired
33+
private CommonConfig config;
34+
2735
@Override
2836
public Mono<ResponseView<InvitationVO>> create(@RequestParam String orgId) {
2937
return invitationApiService.create(orgId)
@@ -50,4 +58,13 @@ public Mono<ResponseView<?>> inviteUser(@PathVariable String invitationId) {
5058
);
5159
}
5260

61+
@Override
62+
public Mono<ResponseView<Boolean>> sendInvitationEmails(InviteEmailRequest req) {
63+
return invitationApiService.create(req.orgId()).map(invitation ->
64+
emailCommunicationService.sendInvitationEmails(req.emails(),
65+
config.getLowcoderPublicUrl() + "/" + invitation.getInviteCode(),
66+
"You have been invited to join our platform. Click here to accept the invitation: %s"))
67+
.map(ResponseView::success);
68+
}
69+
5370
}

server/api-service/lowcoder-server/src/main/java/org/lowcoder/api/usermanagement/InvitationEndpoints.java

+16
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import org.springframework.web.bind.annotation.GetMapping;
88
import org.springframework.web.bind.annotation.PathVariable;
99
import org.springframework.web.bind.annotation.PostMapping;
10+
import org.springframework.web.bind.annotation.RequestBody;
1011
import org.springframework.web.bind.annotation.RequestMapping;
1112
import org.springframework.web.bind.annotation.RequestParam;
1213
import org.springframework.web.bind.annotation.RestController;
@@ -46,5 +47,20 @@ public interface InvitationEndpoints
4647
)
4748
@GetMapping("/{invitationId}/invite")
4849
public Mono<ResponseView<?>> inviteUser(@PathVariable String invitationId);
50+
51+
@Operation(
52+
tags = TAG_INVITATION_MANAGEMENT,
53+
operationId = "sendInvitationEmails",
54+
summary = "Send invitation emails",
55+
description = "Send invitation emails to the specified addresses"
56+
)
57+
@PostMapping("/email/invite")
58+
public Mono<ResponseView<Boolean>> sendInvitationEmails(@RequestBody InviteEmailRequest req);
59+
/**
60+
* @param emails email addresses to send the invitation to
61+
* @param inviteLink the link to be included in the email
62+
*/
63+
public record InviteEmailRequest(String[] emails, String orgId) {
64+
}
4965

5066
}

0 commit comments

Comments
 (0)