Skip to content

Commit 00f90d3

Browse files
authored
Verifier: Reword range metadata error message (#102441)
1 parent 635d20e commit 00f90d3

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

llvm/lib/IR/Verifier.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4142,8 +4142,10 @@ void Verifier::verifyRangeMetadata(const Value &I, const MDNode *Range,
41424142
ConstantInt *High =
41434143
mdconst::dyn_extract<ConstantInt>(Range->getOperand(2 * i + 1));
41444144
Check(High, "The upper limit must be an integer!", High);
4145-
Check(High->getType() == Low->getType() &&
4146-
High->getType() == Ty->getScalarType(),
4145+
4146+
Check(High->getType() == Low->getType(), "Range pair types must match!",
4147+
&I);
4148+
Check(High->getType() == Ty->getScalarType(),
41474149
"Range types must match instruction type!", &I);
41484150

41494151
APInt HighV = High->getValue();

llvm/test/Verifier/absolute_symbol.ll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,11 @@ define void @absolute_func_empty_arguments() !absolute_symbol !0 {
5858
; CHECK-NEXT: ptr @absolute_two_arguments_wrong_width
5959
!4 = !{i32 256, i32 512}
6060

61-
; CHECK-NEXT: Range types must match instruction type!
61+
; CHECK-NEXT: Range pair types must match!
6262
; CHECK-NEXT: ptr @absolute_two_arguments_one_wrong_width0
6363
!5 = !{i32 256, i64 512}
6464

65-
; CHECK-NEXT: Range types must match instruction type!
65+
; CHECK-NEXT: Range pair types must match!
6666
; CHECK-NEXT: ptr @absolute_two_arguments_one_wrong_width1
6767
!6 = !{i64 256, i32 512}
6868

llvm/test/Verifier/range-1.ll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ entry:
4747
ret i8 %y
4848
}
4949
!5 = !{i32 0, i8 0}
50-
; CHECK: Range types must match instruction type!
50+
; CHECK: Range pair types must match!
5151
; CHECK: %y = load
5252

5353
define i8 @f7(ptr %x) {
@@ -56,7 +56,7 @@ entry:
5656
ret i8 %y
5757
}
5858
!6 = !{i8 0, i32 0}
59-
; CHECK: Range types must match instruction type!
59+
; CHECK: Range pair types must match!
6060
; CHECK: %y = load
6161

6262
define i8 @f8(ptr %x) {

0 commit comments

Comments
 (0)