Skip to content

YAML: cpuType should be moved to vmOpts.qemu #3486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AkihiroSuda opened this issue May 2, 2025 · 1 comment · May be fixed by #3500
Open

YAML: cpuType should be moved to vmOpts.qemu #3486

AkihiroSuda opened this issue May 2, 2025 · 1 comment · May be fixed by #3500
Assignees
Labels

Comments

@AkihiroSuda
Copy link
Member

AkihiroSuda commented May 2, 2025

lima/templates/default.yaml

Lines 321 to 340 in 94ed78c

vmOpts:
qemu:
# Minimum version of QEMU required to create an instance of this template.
# Will be ignored if the vmType is not "qemu"
# 🟢 Builtin default: not set
minimumVersion: null
# OS: "Linux".
# 🟢 Builtin default: "Linux"
os: null
# Specify desired QEMU CPU type for each arch.
# You can see what options are available for host emulation with: `qemu-system-$(arch) -cpu help`.
# Setting of instructions is supported like this: "qemu64,+ssse3".
# 🟢 Builtin default: hard-coded arch map with type (see the output of `limactl info | jq .defaultTemplate.cpuType`)
cpuType:
# aarch64: "cortex-a76" # (or "host" when running on aarch64 host)
# armv7l: "cortex-a7" # (or "host" when running on armv7l host)
# riscv64: "rv64" # (or "host" when running on riscv64 host)
# x86_64: "qemu64" # (or "host,-pdpe1gb" when running on x86_64 host)

cpuType is specific to QEMU and not portable to other VM drivers, so it should be moved to vmOpts.qemu.
The structure definition and the implementation should be moved from pkg/limayaml to pkg/qemu too.

For compatibility the old form should continue to be supported for a while.

@unsuman
Copy link
Contributor

unsuman commented May 3, 2025

I'm working on this!

@unsuman unsuman linked a pull request May 6, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants