Skip to content

[bug]: docs for peer_pubkey in AddInvoiceRequest need updating #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZZiigguurraatt opened this issue May 22, 2025 · 0 comments · May be fixed by #1561
Open

[bug]: docs for peer_pubkey in AddInvoiceRequest need updating #1556

ZZiigguurraatt opened this issue May 22, 2025 · 0 comments · May be fixed by #1561
Labels
bug Something isn't working needs triage

Comments

@ZZiigguurraatt
Copy link

At

// The node identity public key of the peer to ask for a quote for receiving
// assets and converting them from satoshis. This must be specified if
// there are multiple channels with the given asset ID.
bytes peer_pubkey = 3;

we make no mention of group_key and also is not correct considering the multi-RFQ functionality that is described here.

/* litcli: `ln addinvoice`
AddInvoice is a wrapper around lnd's lnrpc.AddInvoice method with asset
specific parameters. It allows RPC users to create invoices that correspond
to the specified asset amount. If a peer pubkey is specified, then only that
peer will be used for RFQ negotiations. If none is specified then RFQ quotes
for all peers with suitable asset channels will be created.
*/
rpc AddInvoice (AddInvoiceRequest) returns (AddInvoiceResponse);

@ZZiigguurraatt ZZiigguurraatt added bug Something isn't working needs triage labels May 22, 2025
@GeorgeTsagk GeorgeTsagk linked a pull request May 23, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant