-
Notifications
You must be signed in to change notification settings - Fork 281
Fix libgit2 build scripts #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Set LIBSSH2_INCLUDE_DIR so that libssh2.h can be found
@@ -22,7 +22,11 @@ fi | |||
mkdir build | |||
cd build | |||
|
|||
cmake -DBUILD_SHARED_LIBS:BOOL=OFF -DBUILD_CLAR:BOOL=OFF -DTHREADSAFE:BOOL=ON .. | |||
cmake -DBUILD_SHARED_LIBS:BOOL=OFF \ | |||
-DLIBSSH2_INCLUDE_DIR:PATH=../../External/libssh2-ios/include/libssh2/ \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't be correct for OS X builds, which use the system libssh2 (IIRC).
Thanks! The iOS changes definitely look good, but I'm a bit unsure about the OS X path. |
This reverts commit fd67e2b.
Went ahead and reverted the change to the Mac build script. When I run It's only when I build the libgit2 target in Xcode that it fails.
|
For me both (Mac and iOS) built when I checked out @phatblat branch. Just using the iOS changes didn't solve the building issues. |
Sorry, to be clear: I think Can it use |
|
LIBSSH2_INCLUDE_DIR = /usr/local/include/
Awesome, thanks for tackling this! Works great for me. ✨ |
Fix libgit2 build scripts
I had some trouble getting libgit2 to build in 0.5 and 0.6, getting errors about
'libssh2.h' file not found
. I wasn't sure if it was my setup (been on Xcode and Yosemite betas a lot lately), but by modifying the update_libgit2 scripts and definingLIBSSH2_INCLUDE_DIR
it builds consistently.Addresses #442