feat: [LAR-85] update sitemap

Author: mckenziearts

.gitignore

@@ -20,7 +20,7 @@ composer.phar
 /public/hot
 /public/storage
 /public/media
-/public/sitemap.xml
+/public/**/*.xml
 /storage/*.key
 /storage/framework/cache
 .env

app/Console/Commands/GenerateSitemap.php

@@ -4,54 +4,45 @@
 
 namespace App\Console\Commands;
 
-use App\Models\Article;
 use Illuminate\Console\Command;
-use Illuminate\Support\Str;
-use Psr\Http\Message\UriInterface;
 use Spatie\Sitemap\Sitemap;
-use Spatie\Sitemap\SitemapGenerator;
+use Spatie\Sitemap\SitemapIndex;
 use Spatie\Sitemap\Tags\Url;
 
 final class GenerateSitemap extends Command
 {
     protected $signature = 'sitemap:generate';
 
-    protected $description = 'Crawl the site to generate a sitemap.xml file';
-
-    /**
-     * @var array|string[]
-     */
-    private array $noIndexPaths = [
-        '',
-        '/forum/*',
-        '/user/*',
-    ];
+    protected $description = 'Generate the sitemap';
 
     public function handle(): void
     {
-        SitemapGenerator::create(config('app.url'))
-            ->shouldCrawl(fn (UriInterface $url) => $this->shouldIndex($url->getPath()))
-            ->hasCrawled(function (Url $url) {
-                if ($this->shouldNotIndex($url->path())) {
-                    return;
-                }
-
-                return $url;
-            })
-            ->writeToFile(public_path('sitemap.xml'));
-
         Sitemap::create()
-            ->add(Article::query()->whereNotNull('approved_at')->get())
-            ->writeToFile(public_path('sitemap.xml'));
-    }
-
-    private function shouldNotIndex(string $path): bool
-    {
-        return Str::is($this->noIndexPaths, $path);
-    }
-
-    private function shouldIndex(string $path): bool
-    {
-        return ! $this->shouldNotIndex($path);
+            ->add(
+                Url::create(route('home'))
+                    ->setLastModificationDate(now()->subMinutes(10))
+                    ->setChangeFrequency(Url::CHANGE_FREQUENCY_DAILY)
+                    ->setPriority(0.5)
+            )
+            ->add(
+                Url::create(route('sponsors'))
+                    ->setLastModificationDate(now()->subMinutes(10))
+                    ->setChangeFrequency(Url::CHANGE_FREQUENCY_DAILY)
+                    ->setPriority(0.5)
+            )
+            ->add(
+                Url::create(route('about'))
+                    ->setLastModificationDate(now()->subMinutes(10))
+                    ->setChangeFrequency(Url::CHANGE_FREQUENCY_DAILY)
+                    ->setPriority(0.5)
+            )
+            ->writeToFile(public_path('sitemaps/base_sitemap.xml'));
+
+        $sitemap = SitemapIndex::create()
+            ->add('/sitemaps/base_sitemap.xml')
+            ->add('/sitemaps/discussion_sitemap.xml')
+            ->add('/sitemaps/blog_sitemap.xml');
+
+        $sitemap->writeToFile(public_path('sitemap.xml'));
     }
 }

app/Console/Commands/Sitemap/GenerateArticlesSitemapCommand.php

@@ -0,0 +1,27 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Console\Commands\Sitemap;
+
+use App\Models\Article;
+use Illuminate\Console\Command;
+use Spatie\Sitemap\Sitemap;
+
+final class GenerateArticlesSitemapCommand extends Command
+{
+    protected $signature = 'sitemap:blog-generate';
+
+    protected $description = 'Generate the articles sitemaps.';
+
+    public function handle(): void
+    {
+        $sitemap = Sitemap::create();
+
+        Article::query()->whereNotNull('approved_at')->each(function ($article) use ($sitemap): void {
+            $sitemap->add($article); // @phpstan-ignore-line
+        });
+
+        $sitemap->writeToFile(public_path('sitemaps/blog_sitemap.xml'));
+    }
+}

app/Console/Commands/Sitemap/GenerateDiscussionsSitemapCommand.php

@@ -0,0 +1,27 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Console\Commands\Sitemap;
+
+use App\Models\Discussion;
+use Illuminate\Console\Command;
+use Spatie\Sitemap\Sitemap;
+
+final class GenerateDiscussionsSitemapCommand extends Command
+{
+    protected $signature = 'sitemap:discussion-generate';
+
+    protected $description = 'Generate the discussions sitemaps.';
+
+    public function handle(): void
+    {
+        $sitemap = Sitemap::create();
+
+        Discussion::query()->whereHas('replies')->each(function ($discussion) use ($sitemap): void {
+            $sitemap->add($discussion); // @phpstan-ignore-line
+        });
+
+        $sitemap->writeToFile(public_path('sitemaps/discussion_sitemap.xml'));
+    }
+}

app/Livewire/Components/Discussion/Comments.php

@@ -74,6 +74,7 @@ public function comments(): Collection
     {
         $replies = collect();
 
+        // @phpstan-ignore-next-line
         foreach ($this->discussion->replies->load(['allChildReplies', 'user']) as $reply) {
             /** @var Reply $reply */
             if ($reply->allChildReplies->isNotEmpty()) {

app/Models/Article.php

@@ -36,14 +36,14 @@
  * @property int $user_id
  * @property string | null $locale
  * @property-read User $user
- * @property \Carbon\Carbon | null $published_at
- * @property \Carbon\Carbon | null $submitted_at
- * @property \Carbon\Carbon | null $approved_at
- * @property \Carbon\Carbon | null $shared_at
- * @property \Carbon\Carbon | null $declined_at
- * @property \Carbon\Carbon | null $sponsored_at
- * @property \Carbon\Carbon $created_at
- * @property \Carbon\Carbon $updated_at
+ * @property Carbon | null $published_at
+ * @property Carbon | null $submitted_at
+ * @property Carbon | null $approved_at
+ * @property Carbon | null $shared_at
+ * @property Carbon | null $declined_at
+ * @property Carbon | null $sponsored_at
+ * @property Carbon $created_at
+ * @property Carbon $updated_at
  * @property \Illuminate\Database\Eloquent\Collection | Tag[] $tags
  */
 final class Article extends Model implements HasMedia, ReactableInterface, Sitemapable, Viewable
@@ -99,6 +99,14 @@ public function newEloquentBuilder($query): ArticleQueryBuilder
         return new ArticleQueryBuilder($query);
     }
 
+    public function toSitemapTag(): Url
+    {
+        return Url::create(route('articles.show', $this))
+            ->setLastModificationDate(Carbon::create($this->updated_at)) // @phpstan-ignore-line
+            ->setChangeFrequency(Url::CHANGE_FREQUENCY_YEARLY)
+            ->setPriority(0.5);
+    }
+
     public function excerpt(int $limit = 110): string
     {
         return Str::limit(strip_tags((string) md_to_html($this->body)), $limit);
@@ -240,12 +248,4 @@ public function delete(): ?bool
 
         return parent::delete();
     }
-
-    public function toSitemapTag(): Url|string|array
-    {
-        return Url::create(route('articles.show', $this))
-            ->setLastModificationDate(Carbon::create($this->updated_at))
-            ->setChangeFrequency(Url::CHANGE_FREQUENCY_YEARLY)
-            ->setPriority(0.1);
-    }
 }

app/Models/Discussion.php

@@ -26,6 +26,8 @@
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Support\Collection;
 use Illuminate\Support\Str;
+use Spatie\Sitemap\Contracts\Sitemapable;
+use Spatie\Sitemap\Tags\Url;
 
 /**
  * @property-read int $id
@@ -41,8 +43,9 @@
  * @property Carbon $updated_at
  * @property User $user
  * @property Collection | SpamReport[] $spamReports
+ * @property Collection | Reply[] $replies
  */
-final class Discussion extends Model implements ReactableInterface, ReplyInterface, SpamReportableContract, SubscribeInterface, Viewable
+final class Discussion extends Model implements ReactableInterface, ReplyInterface, Sitemapable, SpamReportableContract, SubscribeInterface, Viewable
 {
     use HasAuthor;
     use HasFactory;
@@ -107,6 +110,14 @@ public function excerpt(int $limit = 110): string
         return Str::limit(strip_tags((string) md_to_html($this->body)), $limit);
     }
 
+    public function toSitemapTag(): Url
+    {
+        return Url::create(route('discussions.show', $this))
+            ->setLastModificationDate(Carbon::create($this->updated_at)) // @phpstan-ignore-line
+            ->setChangeFrequency(Url::CHANGE_FREQUENCY_YEARLY)
+            ->setPriority(0.5);
+    }
+
     public function isPinned(): bool
     {
         return $this->is_pinned;

public/sitemaps/.gitkeep

@@ -4,7 +4,12 @@
 
 use Illuminate\Foundation\Inspiring;
 use Illuminate\Support\Facades\Artisan;
+use Illuminate\Support\Facades\Schedule;
 
 Artisan::command('inspire', function (): void {
     $this->comment(Inspiring::quote());
 })->purpose('Display an inspiring quote')->hourly();
+
+Schedule::command('sitemap:blog-generate')->dailyAt('01:00');
+Schedule::command('sitemap:discussion-generate')->dailyAt('01:10');
+Schedule::command('sitemap:generate')->dailyAt('02:00');