Skip to content

Commit f25e77f

Browse files
committed
Remove unnecessary wrapping of function call
1 parent 27af642 commit f25e77f

File tree

4 files changed

+6
-26
lines changed

4 files changed

+6
-26
lines changed

.deepsource.toml

Lines changed: 0 additions & 12 deletions
This file was deleted.

binder.go

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -101,10 +101,8 @@ type ValueBinder struct {
101101
// QueryParamsBinder creates query parameter value binder
102102
func QueryParamsBinder(c Context) *ValueBinder {
103103
return &ValueBinder{
104-
failFast: true,
105-
ValueFunc: func(sourceParam string) string {
106-
return c.QueryParam(sourceParam)
107-
},
104+
failFast: true,
105+
ValueFunc: c.QueryParam,
108106
ValuesFunc: func(sourceParam string) []string {
109107
values, ok := c.QueryParams()[sourceParam]
110108
if !ok {
@@ -119,10 +117,8 @@ func QueryParamsBinder(c Context) *ValueBinder {
119117
// PathParamsBinder creates path parameter value binder
120118
func PathParamsBinder(c Context) *ValueBinder {
121119
return &ValueBinder{
122-
failFast: true,
123-
ValueFunc: func(sourceParam string) string {
124-
return c.Param(sourceParam)
125-
},
120+
failFast: true,
121+
ValueFunc: c.Param,
126122
ValuesFunc: func(sourceParam string) []string {
127123
// path parameter should not have multiple values so getting values does not make sense but lets not error out here
128124
value := c.Param(sourceParam)

middleware/rate_limiter.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,4 @@ func (store *RateLimiterMemoryStore) cleanupStaleVisitors() {
263263
/*
264264
actual time method which is mocked in test file
265265
*/
266-
var now = func() time.Time {
267-
return time.Now()
268-
}
266+
var now = time.Now

middleware/rate_limiter_test.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -350,9 +350,7 @@ func TestRateLimiterMemoryStore_Allow(t *testing.T) {
350350

351351
func TestRateLimiterMemoryStore_cleanupStaleVisitors(t *testing.T) {
352352
var inMemoryStore = NewRateLimiterMemoryStoreWithConfig(RateLimiterMemoryStoreConfig{Rate: 1, Burst: 3})
353-
now = func() time.Time {
354-
return time.Now()
355-
}
353+
now = time.Now
356354
fmt.Println(now())
357355
inMemoryStore.visitors = map[string]*Visitor{
358356
"A": {

0 commit comments

Comments
 (0)