-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Add proxy support via environment variables #1175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The |
Nice, thanks for pointing me to the template for this class. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Closing this issue since this is something that should be resolved on the OpenAPI side (I haven't done so yet though). |
What is the feature and why do you need it:
Most programs detect that they must use a proxy by checking the
http_proxy
/https_proxy
environment variables. See for example this section ofrequests
on proxying: https://github.com/request/request#controlling-proxy-behaviour-using-environment-variablesThis is not the case here though, as the user must explicitly override the
.proxy
argument of theConfiguration
class, in order to enable proxying.python/kubernetes/client/configuration.py
Line 99 in b6e4ae8
Describe the solution you'd like to see:
The
Configuration
class should auto-detect the appropriate environment variables and pass them tourllib3
, given thaturllib3
has chosen not to do it (urllib3/urllib3#1785). If this proposal makes sense, I could open a PR.The text was updated successfully, but these errors were encountered: