Skip to content
This repository was archived by the owner on Jun 14, 2018. It is now read-only.

ambiguous istioctl commands (istioctl mixer rule create and istioctl create) #710

Closed
rshriram opened this issue May 10, 2017 · 5 comments
Closed

Comments

@rshriram
Copy link
Member

Istioctl mixer commands use explicit verbs and resource names in the command line, resulting in both longer command lines and ambiguous command set.. The commands for route rules are
istioctl create|get|replace|delete -f <filename>
while the commands for mixer are
istioctl mixer rule create|get. There is no istioctl mixer rule replace|delete.

The documentation and usage is pretty confusing. The two formats need to be unified into something like
istioctl create|get|replace|delete -f <filename>, where the type of the command, resource, etc. can be specified as part of the YAML file. for example

cat <<EOF | istioctl create
type: mixer-rule
name: ratelimit
spec:
 rules:
 - aspects:
   - kind: quotas
     params:
       quotas:
       - descriptorName: RequestCount
         maxAmount: 5
         expiration: 1s
EOF

The command structure and documentation of istioctl command is not cohesive. Its messy at the moment. Istioctl replace follows istioctl mixer rule.

Need to fix this before final release.

Ccing folks who worked on istioctl. @esnible @mandarjog @ayj
cc @geeknoid

@rshriram rshriram added the bug label May 10, 2017
@rshriram rshriram added this to the manager alpha milestone May 10, 2017
@ayj
Copy link
Contributor

ayj commented May 10, 2017

I already created #649 to track this issue but it was targeted for beta.

@douglas-reid douglas-reid modified the milestones: manager beta, manager alpha May 10, 2017
@kyessenov
Copy link
Contributor

This is what mixer gives to us.

@kyessenov
Copy link
Contributor

The work has to start from making changes to mixer to organize the configs. The hacky solution is to parse YAMLs in apiserver and dispatch them to mixer config server after rewriting URLs and content.

@ayj
Copy link
Contributor

ayj commented May 11, 2017

We can hack istioctl to use common top-level verbs but the specific syntax is likely to change in beta as we straightout the config API and server story. API server version checking could help for this early pre-beta breaking changes.

@kyessenov
Copy link
Contributor

Issue moved to istio/galley #10 via ZenHub

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants