Skip to content

Commit cb0354b

Browse files
committed
Add DEFAULT to AuthenticationPolicy enum.
1 parent 49f4ba8 commit cb0354b

File tree

1 file changed

+30
-18
lines changed

1 file changed

+30
-18
lines changed

proxy/v1/config/proxy_mesh.proto

Lines changed: 30 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,14 @@ import "google/protobuf/duration.proto";
1818

1919
package istio.proxy.v1.config;
2020

21+
// AuthenticationPolicy defines authentication policy. It can be defined at
22+
// the mesh level or per-service (and even lower, e.g per-deployment).
23+
// Policy from lower level, if know, will overrule those above it.
2124
enum AuthenticationPolicy {
25+
// Indicate policy should be derived from 'parent'
26+
// This should never be used for mesh's policy.
27+
UNKNOWN = -1;
28+
2229
// Do not encrypt Envoy to Envoy traffic.
2330
NONE = 0;
2431

@@ -29,7 +36,8 @@ enum AuthenticationPolicy {
2936
// ProxyConfig defines variables for individual Envoy instances.
3037
message ProxyConfig {
3138
// Path to the generated configuration file directory.
32-
// Proxy agent generates the actual configuration and stores it in this directory.
39+
// Proxy agent generates the actual configuration and stores it in this
40+
// directory.
3341
string config_path = 1;
3442

3543
// Path to the proxy binary
@@ -62,7 +70,8 @@ message ProxyConfig {
6270
// Address of the discovery service exposing xDS (e.g. _istio-pilot:8080_).
6371
string discovery_address = 6;
6472

65-
// Polling interval for service discovery (used by EDS, CDS, LDS, but not RDS). (MUST BE >=1ms)
73+
// Polling interval for service discovery (used by EDS, CDS, LDS, but not
74+
// RDS). (MUST BE >=1ms)
6675
google.protobuf.Duration discovery_refresh_delay = 7;
6776

6877
// Address of the Zipkin service (e.g. _zipkin:9411_).
@@ -76,29 +85,30 @@ message ProxyConfig {
7685

7786
// Port on which Envoy should listen for administrative commands.
7887
int32 proxy_admin_port = 11;
79-
88+
8089
// The availability zone where this Envoy instance is running. When running
8190
// Envoy as a sidecar in Kubernetes, this flag must be one of the availability
82-
// zones assigned to a node using failure-domain.beta.kubernetes.io/zone annotation.
91+
// zones assigned to a node using failure-domain.beta.kubernetes.io/zone
92+
// annotation.
8393
string availability_zone = 12;
8494

8595
// Authentication policy defines the global switch to control authentication
8696
// for Envoy-to-Envoy communication for istio components Mixer and Pilot.
8797
AuthenticationPolicy control_plane_auth_policy = 13;
88-
98+
8999
// File path of custom proxy configuration, currently used by proxies
90100
// in front of Mixer and Pilot.
91101
string custom_config_file = 14;
92102

93-
// Maximum length of name field in Envoy's metrics. The length of the name field
94-
// is determined by the length of a name field in a service and the set of labels that
95-
// comprise a particular version of the service. The default value is set to 189 characters.
96-
// Envoy's internal metrics take up 67 characters, for a total of 256 character name per metric.
97-
// Increase the value of this field if you find that the metrics from Envoys are truncated.
103+
// Maximum length of name field in Envoy's metrics. The length of the name
104+
// field is determined by the length of a name field in a service and the set
105+
// of labels that comprise a particular version of the service. The default
106+
// value is set to 189 characters. Envoy's internal metrics take up 67
107+
// characters, for a total of 256 character name per metric. Increase the
108+
// value of this field if you find that the metrics from Envoys are truncated.
98109
int32 stat_name_length = 15;
99110
}
100111

101-
102112
// MeshConfig defines mesh-wide variables shared by all Envoy instances in the
103113
// Istio service mesh.
104114
message MeshConfig {
@@ -151,10 +161,12 @@ message MeshConfig {
151161
STRICT = 2;
152162
}
153163

154-
// Defines whether to use Istio ingress controller for annotated or all ingress resources.
164+
// Defines whether to use Istio ingress controller for annotated or all
165+
// ingress resources.
155166
IngressControllerMode ingress_controller_mode = 9;
156167

157-
// TODO AuthPolicy needs to be removed and merged with AuthPolicy defined above
168+
// TODO AuthPolicy needs to be removed and merged with AuthPolicy defined
169+
// above
158170
enum AuthPolicy {
159171
// Do not encrypt Envoy to Envoy traffic.
160172
NONE = 0;
@@ -178,10 +190,10 @@ message MeshConfig {
178190
// Empty value disables access logging.
179191
string access_log_file = 13;
180192

181-
// Default proxy config used by the proxy injection mechanism operating in the mesh
182-
// (e.g. Kubernetes admission controller)
183-
// In case of Kubernetes, the proxy config is applied once during the injection process,
184-
// and remain constant for the duration of the pod. The rest of the mesh config can be changed
185-
// at runtime and config gets distributed dynamically.
193+
// Default proxy config used by the proxy injection mechanism operating in the
194+
// mesh (e.g. Kubernetes admission controller) In case of Kubernetes, the
195+
// proxy config is applied once during the injection process, and remain
196+
// constant for the duration of the pod. The rest of the mesh config can be
197+
// changed at runtime and config gets distributed dynamically.
186198
ProxyConfig default_config = 14;
187199
}

0 commit comments

Comments
 (0)