Not exposing mithril-core in mithril-common

Author: iquerejeta

Cargo.lock

@@ -14,6 +14,7 @@ cloud-storage = "0.11.0"
 config = "0.13.1"
 flate2 = "1.0.23"
 hex = "0.4.3"
+mithril = { path = "../mithril-core" }
 mithril-common = { path = "../mithril-common" }
 reqwest = { version = "0.11", features = ["json"] }
 serde = { version = "1.0", features = ["derive"] }
@@ -36,4 +37,4 @@ slog-term = "2.9.0"
 tempfile = "3.3.0"
 
 [features]
-portable = ["mithril-common/portable"]
+portable = ["mithril/portable"]

mithril-aggregator/Cargo.toml

@@ -5,14 +5,14 @@ use chrono::prelude::*;
 use slog_scope::{debug, trace, warn};
 use thiserror::Error;
 
+use mithril::AggregationError;
 use mithril_common::crypto_helper::{
     key_decode_hex, key_encode_hex, ProtocolAggregateVerificationKey, ProtocolClerk,
     ProtocolKeyRegistration, ProtocolMultiSignature, ProtocolParameters, ProtocolPartyId,
     ProtocolSignerVerificationKey, ProtocolSingleSignature, ProtocolStakeDistribution,
     PROTOCOL_VERSION,
 };
 use mithril_common::entities::{self, SignerWithStake};
-use mithril_common::mithril::AggregationError;
 use mithril_common::store::{StakeStoreError, StakeStorer};
 use mithril_common::{
     NEXT_SIGNER_EPOCH_RETRIEVAL_OFFSET, SIGNER_EPOCH_RECORDING_OFFSET,

mithril-aggregator/src/multi_signer.rs

@@ -25,8 +25,6 @@ pub mod store;
 pub use beacon_provider::{BeaconProvider, BeaconProviderError, BeaconProviderImpl};
 pub use entities::{CardanoNetwork, MagicId};
 
-pub use mithril;
-
 // TODO: Investigate as why signers can't sign until epoch 3 (in the e2e) when set to -1
 /// The epoch offset used for signers stake distribution and verification keys retrieval.
 pub const SIGNER_EPOCH_RETRIEVAL_OFFSET: i64 = -1;