Audit default Builder options #3279
Labels
C-refactor
Category: refactor. This would improve the clarity of internal code.
E-medium
Effort: medium. Some knowledge of how hyper internal works would be useful.
Milestone
Prior to marking hyper 1.0, it would be wise to audit all the default options in the various connection
Builder
s. While changing them would be a compilation breaking change, it would be a behavioral change. (We could add a note that default options are not meant to be relied upon, that setting them explicitly is better, and thus reserve the ability to change defaults?)This issue balances two of hyper's tenets: Correct vs Flexible. The existence of an option fulfills flexible, but as that tenet description points out, we should favor the default being safer, since Correct is more important.
I know some of the options that should probably include defaults are slightly tricky: timeouts. They only work if a
impl Timer
is provided, otherwise they can't set any timeouts. But we can discuss here how best to handle that: default on but only enabled if a timer is provided, warn if a timer is not provided, or require a timer be provided.Action Items
Timer
#3393The text was updated successfully, but these errors were encountered: