Skip to content
This repository was archived by the owner on Jun 8, 2021. It is now read-only.

Rename WidgetExt::set_name() and BuildableExt::set_name() #914

Closed
sdroege opened this issue Nov 19, 2019 · 2 comments · Fixed by #917
Closed

Rename WidgetExt::set_name() and BuildableExt::set_name() #914

sdroege opened this issue Nov 19, 2019 · 2 comments · Fixed by #917

Comments

@sdroege
Copy link
Member

sdroege commented Nov 19, 2019

And also get_name(). Currently it's inconvenient that they have the same name because you have to call them by also specifying the trait.

I would suggest set_widget_name() and set_buildable_name(). We should probably do the same for other duplicated functions.

@GuillaumeGomez @EPashkin opinions?
@EPashkin
Copy link
Member

Agree

@sdroege sdroege mentioned this issue Nov 19, 2019
Closed
43 tasks
@GuillaumeGomez
Copy link
Member

I agree as well. I'll take a look.

@GuillaumeGomez GuillaumeGomez mentioned this issue Nov 19, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add renaming for WidgetExt::set_name and BuildableExt::set_name GuillaumeGomez/gtk
3 participants
@sdroege @EPashkin @GuillaumeGomez