Skip to content
This repository was archived by the owner on Jun 8, 2021. It is now read-only.

Impossible to distinguish Value::get::<glib::Object>() returning None because type mismatch or no value contained #510

Closed
sdroege opened this issue Aug 5, 2019 · 7 comments · Fixed by #513
Closed

Impossible to distinguish Value::get::<glib::Object>() returning None because type mismatch or no value contained #510

sdroege opened this issue Aug 5, 2019 · 7 comments · Fixed by #513

Comments

@sdroege
Copy link
Member

sdroege commented Aug 5, 2019

We should probably change the signature so that it returns a Result, and in case of nullable types (like objects) the success case of the Result would be an Option. The error case of the Result would happen on type mismatches.

Opinions?
@fengalin
Copy link
Contributor

fengalin commented Aug 5, 2019

I agree!

@sdroege
Copy link
Member Author

sdroege commented Aug 5, 2019

@GuillaumeGomez @EPashkin

@GuillaumeGomez
Copy link
Member

I agree as well.

@EPashkin
Copy link
Member

EPashkin commented Aug 5, 2019

I also agree

@sdroege
Copy link
Member Author

sdroege commented Aug 6, 2019

Ok, so now we only need to implement it then :)

@fengalin
Copy link
Contributor

fengalin commented Aug 6, 2019

Ok, so now we only need to implement it then :)

I can do that!

@GuillaumeGomez
Copy link
Member

@fengalin Then go for it! :)

@fengalin fengalin mentioned this issue Aug 7, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Value::get: return a Result to account for type mismatch...
4 participants
@sdroege @EPashkin @GuillaumeGomez @fengalin