Skip to content

Teach Android build -PfailOnWarnings=true #6868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ejona86 opened this issue Mar 27, 2020 · 0 comments · May be fixed by #12040
Open

Teach Android build -PfailOnWarnings=true #6868

ejona86 opened this issue Mar 27, 2020 · 0 comments · May be fixed by #12040
Labels
code health
Milestone
Next

Comments

@ejona86
Copy link
Member

ejona86 commented Mar 27, 2020

Multiple of our CIs currently run with -PfailOnWarnings=true. This is observed by our main build.gradle to enable -Werror:

grpc-java/build.gradle

Lines 39 to 41 in 9dec06c

if (rootProject.hasProperty('failOnWarnings') && rootProject.failOnWarnings.toBoolean()) {
it.options.compilerArgs += ["-Werror"]
}

We should observe the property for Android as well. This will help keep our builds clean and prevent things like #6866.

Android also has a fair number of linter warnings. It would be nice if we got to a place where they were covered by -PfailOnWarnings=true as well, but that could happen later (in which case we should create a new issue to track it).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code health
Projects
None yet
Milestone
Next
2 participants
@voidzcy @ejona86