Skip to content

Commit 89727b8

Browse files
authored
Merge pull request #15 from graphql-python/middleware-executor-improvement
Simplified schema logic for the GraphQLView
2 parents 66a10ad + 3847069 commit 89727b8

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

flask_graphql/graphqlview.py

+8-9
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,6 @@ def __init__(self, **kwargs):
4040
if hasattr(self, key):
4141
setattr(self, key, value)
4242

43-
inner_schema = getattr(self.schema, 'schema', None)
44-
if not self.executor:
45-
self.executor = getattr(self.schema, 'executor', None)
46-
47-
if inner_schema:
48-
self.schema = inner_schema
49-
5043
assert isinstance(self.schema, GraphQLSchema), 'A Schema is required to be provided to GraphQLView.'
5144

5245
# noinspection PyUnusedLocal
@@ -56,6 +49,12 @@ def get_root_value(self, request):
5649
def get_context(self, request):
5750
return request
5851

52+
def get_middleware(self, request):
53+
return self.middleware
54+
55+
def get_executor(self, request):
56+
return self.executor
57+
5958
def dispatch_request(self):
6059
try:
6160
if request.method.lower() not in ('get', 'post'):
@@ -181,8 +180,8 @@ def execute_graphql_request(self, data, query, variables, operation_name, show_g
181180
variable_values=variables or {},
182181
operation_name=operation_name,
183182
context_value=self.get_context(request),
184-
middleware=self.middleware,
185-
executor=self.executor
183+
middleware=self.get_middleware(request),
184+
executor=self.get_executor(request)
186185
)
187186
except Exception as e:
188187
return ExecutionResult(errors=[e], invalid=True)

0 commit comments

Comments
 (0)