Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

Deprecated introspectionEnabled but new property not accepted #402

Closed
ubarua123 opened this issue Apr 25, 2020 · 3 comments
Closed

Deprecated introspectionEnabled but new property not accepted #402

ubarua123 opened this issue Apr 25, 2020 · 3 comments
Labels
Milestone

Comments

@ubarua123
Copy link

I am on graphql-spring-boot-autoconfigure version 7.0.1. I suddenly see that graphql.tools.introspection-enabled is deprecated. The new property is graphql.tools.schema-parser-options.introspection-enabled but springboot can't find it neither is it accepted.
Can anybody point me to what am I doing wrong?

image

And because of this, I had managed to turn off introspection logging, now that's back on polluting the entire console. I have both the properties in my project and I don't know which ones working.

@setchy
Copy link
Member

setchy commented Sep 19, 2020

I have the same problem @ubarua123. I am looking to disable introspection within my production environment, but neither the deprecated property graphql.tools.introspection-enabled or its suggested successor graphql.tools.schema-parser-options.introspection-enabled are working

Raised a separate issue over in graphql-java-tools graphql-java-kickstart/graphql-java-tools#438

@setchy
Copy link
Member

setchy commented Sep 19, 2020

After a little bit of digging I've discovered this feature has been replaced by using
GraphqlFieldVisibility

As an example

@Bean
GraphqlFieldVisibility disableIntrospection() {
   return new NoIntrospectionGraphqlFieldVisibility();
}

@oliemansm oliemansm added the bug label Dec 19, 2020
@oliemansm
Copy link
Member

@setchy Thanks for pointing out the workaround. I've reinstated the original property that is also still mentioned in the README. When set to false it'll instantiate the NoIntrospectionGraphqlFieldVisibility bean like your example. It'll log a warning about putting your server in contravention of the GraphQL specification when doing so.

@oliemansm oliemansm added this to the 8.1.0 milestone Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants