Skip to content

Commit ef5e454

Browse files
committed
fix: send proper SSE for stderr message in SDK server
Signed-off-by: Donnie Adams <[email protected]>
1 parent fde5920 commit ef5e454

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

pkg/sdkserver/run.go

+4-2
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,9 @@ func processEventStreamOutput(ctx context.Context, logger mvl.Logger, w http.Res
7575
"stdout": out,
7676
})
7777
case err := <-errChan:
78-
writeError(logger, w, http.StatusInternalServerError, fmt.Errorf("failed to run file: %w", err))
78+
writeServerSentEvent(logger, w, map[string]any{
79+
"stderr": fmt.Sprintf("failed to run: %v", err),
80+
})
7981
}
8082

8183
// Now that we have received all events, send the DONE event.
@@ -145,7 +147,7 @@ func writeError(logger mvl.Logger, w http.ResponseWriter, code int, err error) {
145147

146148
b, err := json.Marshal(resp)
147149
if err != nil {
148-
_, _ = w.Write([]byte(fmt.Sprintf(`{"stderr": "%s"}`, err.Error())))
150+
_, _ = w.Write([]byte(fmt.Sprintf(`{"stderr": "%s"}\n\n`, err.Error())))
149151
return
150152
}
151153

0 commit comments

Comments
 (0)