Skip to content

Knowledge - source links presented in the message response reloads the current chat thread #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sangee2004 opened this issue Aug 24, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@sangee2004
Copy link

sangee2004 commented Aug 24, 2024

Electron build from - b4977d0

Steps to reproduce the problem:

  1. Start a chat with Tildy
  2. Use Add Knowledge to add a file
  3. Ask for some information about the knowledge file.
  4. Wait for the response to be presented with source links
Screenshot 2024-08-23 at 5 23 25 PM
  1. Click the source links presented in the message response.
    This results in the chat view being reloaded and user is presented with the most recent chat thread view.

Expected Behavior:
When source link is clicked , we should be able to open the page of knowledge document that is referenced in the source.

Screen.Recording.2024-08-26.at.9.32.22.AM.mov
@sangee2004 sangee2004 added bug Something isn't working help wanted Extra attention is needed labels Aug 24, 2024
@cjellick
Copy link
Contributor

The link should definitely not cause the chat to reload, but i'm not sure exactly how we should handle this. The file is local, so im not sure how wed open it and almost certianly cannot reliable open it to the right page. Maybe we just say what doc it was instead of linking to it

@cjellick cjellick removed the help wanted Extra attention is needed label Aug 27, 2024
@cjellick
Copy link
Contributor

To clarify further - the knowledge tool explicitly SHOULD NOT return references to docs by default

@cjellick
Copy link
Contributor

@StrongMonkey how feasible for is it going to be for the link to a reference of a knowledge do to actually point at the doc on disk so that it can be opened?

@cjellick
Copy link
Contributor

@StrongMonkey im going to just asign this one to you. two parter:

  1. generally, a link should not cause the chat to reload
  2. for knowledge, either dont provide links or provide a link that opens the pdf on disk. im not sure how hard this will be

@cjellick cjellick assigned StrongMonkey and unassigned g-linville Aug 31, 2024
@StrongMonkey
Copy link
Contributor

@cjellick I think it should be feasible as long as the link is the actual file path. I will give it a try

@StrongMonkey
Copy link
Contributor

The root issue seems to be that our markdown parser didn't render the file link properly, causing an empty href. Trying to fix it now.

@sangee2004
Copy link
Author

Tested with 8809ed131d3

Source link provided now opens the file as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants