-
Notifications
You must be signed in to change notification settings - Fork 12
Knowledge - source links presented in the message response reloads the current chat thread #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The link should definitely not cause the chat to reload, but i'm not sure exactly how we should handle this. The file is local, so im not sure how wed open it and almost certianly cannot reliable open it to the right page. Maybe we just say what doc it was instead of linking to it |
To clarify further - the knowledge tool explicitly SHOULD NOT return references to docs by default |
@StrongMonkey how feasible for is it going to be for the link to a reference of a knowledge do to actually point at the doc on disk so that it can be opened? |
@StrongMonkey im going to just asign this one to you. two parter:
|
@cjellick I think it should be feasible as long as the link is the actual file path. I will give it a try |
The root issue seems to be that our markdown parser didn't render the file link properly, causing an empty href. Trying to fix it now. |
Tested with Source link provided now opens the file as expected. |
Electron build from - b4977d0
Steps to reproduce the problem:
This results in the
chat
view being reloaded and user is presented with the most recent chat thread view.Expected Behavior:
When source link is clicked , we should be able to open the page of knowledge document that is referenced in the source.
Screen.Recording.2024-08-26.at.9.32.22.AM.mov
The text was updated successfully, but these errors were encountered: