Skip to content

Document @noinline #3299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
realityforge opened this issue Mar 27, 2019 · 2 comments
Closed

Document @noinline #3299

realityforge opened this issue Mar 27, 2019 · 2 comments
Labels
internal-issue-created An internal Google issue has been created to track this GitHub issue triage-done Has been reviewed by someone on triage rotation.

Comments

@realityforge
Copy link
Contributor

I was just directed to an issue that indicates @noinline is supported by the compiler but it is not documented on the wiki. It would be great if a short description was that indicated any of the non-obvious implications ... if there are any :)

@blickly
Copy link
Contributor

blickly commented Mar 28, 2019

Internal issue created http://b/129431114

@blickly blickly added triage-done Has been reviewed by someone on triage rotation. internal-issue-created An internal Google issue has been created to track this GitHub issue labels Mar 28, 2019
@lauraharker
Copy link
Contributor

I added https://github.com/google/closure-compiler/wiki/Annotating-JavaScript-for-the-Closure-Compiler#noinline.

The only non-obvious implication is that there may be code paths in the compiler that do not honor this annotation, although it works in the common case. (See Bradford's comment here #2751 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal-issue-created An internal Google issue has been created to track this GitHub issue triage-done Has been reviewed by someone on triage rotation.
Projects
None yet
Development

No branches or pull requests

3 participants