fix gfp12 MulScalar

kc1212 · web-flow · commit ec40c0403614 · 2018-12-15T20:51:43.000+01:00
Previously MulScalar was ignoring the first parameter, which was inconsistent with gfp6 and gfp2.
diff --git a/bn256/gfp12.go b/bn256/gfp12.go
@@ -125,8 +125,8 @@ func (e *gfP12) Mul(a, b *gfP12, pool *bnPool) *gfP12 {
 }
 
 func (e *gfP12) MulScalar(a *gfP12, b *gfP6, pool *bnPool) *gfP12 {
-	e.x.Mul(e.x, b, pool)
-	e.y.Mul(e.y, b, pool)
+	e.x.Mul(a.x, b, pool)
+	e.y.Mul(a.y, b, pool)
 	return e
 }
 

Original file line number	Diff line number	Diff line change
`@@ -125,8 +125,8 @@ func (e gfP12) Mul(a, b gfP12, pool bnPool) gfP12 {`
`125`	`125`	`}`
`126`	`126`
`127`	`127`	`func (e gfP12) MulScalar(a gfP12, b gfP6, pool bnPool) *gfP12 {`
`128`		`- e.x.Mul(e.x, b, pool)`
`129`		`- e.y.Mul(e.y, b, pool)`
	`128`	`+ e.x.Mul(a.x, b, pool)`
	`129`	`+ e.y.Mul(a.y, b, pool)`
`130`	`130`	`return e`
`131`	`131`	`}`
`132`	`132`