Skip to content

API-inconsistency for issue-comments #3673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 of 6 tasks
bkcsoft opened this issue Sep 19, 2016 · 0 comments
Open
1 of 6 tasks

API-inconsistency for issue-comments #3673

bkcsoft opened this issue Sep 19, 2016 · 0 comments
Assignees
@bkcsoft
Labels
💊 bug Something isn't working status: assigned to maintainer Welcome onboard

Comments

@bkcsoft
Copy link
Contributor

bkcsoft commented Sep 19, 2016

Description

As per the API wiki Gogs aims to be compatible with GitHub API which it currently isn't if you compare these endpoints:
https://developer.github.com/v3/issues/comments/#edit-a-comment
https://github.com/gogits/go-gogs-client/wiki/Issues-Comments#edit-a-comment

IMO this should be fixed so existing GitHub-libs can be used for communicating with Gogs. @unknwon agreed when I discussed this with him on Gitter.
@bkcsoft bkcsoft added 💊 bug Something isn't working status: assigned to maintainer Welcome onboard labels Sep 19, 2016
@bkcsoft bkcsoft self-assigned this Sep 19, 2016
@bkcsoft bkcsoft mentioned this issue Sep 23, 2016
Merged
@bkcsoft bkcsoft mentioned this issue Nov 4, 2016
Closed
Martchus pushed a commit to Martchus/gogs that referenced this issue Aug 27, 2018
@stevegt @lunny
Create api-usage doc page (gogs#4306)
aaf6be3 
* add api user guides in doc

* update user-guides api page

* fix typo: user guides -> user guide

* move api-usage page under advanced category

* flesh out API usage docs

* Build on work by @tungsheng

* Address issues raised in gogs#4037, gogs#3673, and gogs#4243

* Close gogs#4247

Signed-off-by: Steve Traugott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkcsoft bkcsoft

Labels
💊 bug Something isn't working status: assigned to maintainer Welcome onboard
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bkcsoft