Type-safe signals from Godot-defined structs

[atollk]

I just saw that type-safe signals have recently been added to godot-rust, including a chapter in the book. That chapter solely focuses on signals defined in custom classes. Is there a way to use signals defined by the Godot library in types like Node in a type-safe way? Is this still work in progress (considering it's just on the master branch, not a released version)?

#[godot_api]
impl IArea2D for Player {
    fn ready(&mut self) {
        self.base().signals().body_entered().connect(/* ... */);
    }
}

[Bromeon]

I just implemented this, see linked PR 🙂

[atollk]

Awesome!
I noticed that it does work for some structs now but it still doesn't for some others. So, I understand that this is still in very active development then and it probably isn't a good idea to use signals for now?

[Bromeon]

I noticed that it does work for some structs now but it still doesn't for some others.

Can you be specific? So far, signals are only defined on the classes that declare them, not derived ones.
But what "doesn't work"?

So, I understand that this is still in very active development then and it probably isn't a good idea to use signals for now?

Yes, signal implementation is an incremental process, and 1 PR being merged doesn't mean "every feature one can ever wish for is now there" 😀 see also #1112 (comment).

Whether it's a good idea depends on your use case. I don't expect major breaking changes, and in several places it's already much better than the alternative (untyped signals). But of course, it still needs ironing out, and suggestions on how to implement things are welcome.

---

Fun coincidence: 😎

[atollk]

Whether it's a good idea depends on your use case.

I meant more like, because it's an incremental process, when I start using type-safe signals now, I will probably run into missing or buggy functionality, at which point it is unclear to me if I should open another issue or if that's already known, just not implemented.

But what "doesn't work"?

Specifically, the Button struct does not implement WithSignals, so it cannot be used with the new interface.

[Bromeon]

Specifically, the Button struct does not implement WithSignals, so it cannot be used with the new interface.

That's because Button itself does not expose any signals, these are available on BaseButton.

Part of #1112 is to come up with a mechanism that allows inheritance of signals, to give the illusion that Button itself provides those signals (like in GDScript).