Typed signals in another file are private

[austin226]

In signal_test.rs, the test signal_symbols_external illustrates that we can connect to an external object's signals by using the emitter.signals() method.

However, if Emitter is located in another file, its signals are private from the perspective of the receiver. Attempting to make the signals public results in a compilation error:

#[signal] must not have a visibility specifier; signals are always public

---

For instance if I make the following change, the compiler gives me an error:

diff --git a/itest/rust/src/builtin_tests/containers/signal_test.rs b/itest/rust/src/builtin_tests/containers/signal_test.rs
index 6aa40494..645082c7 100644
--- a/itest/rust/src/builtin_tests/containers/signal_test.rs
+++ b/itest/rust/src/builtin_tests/containers/signal_test.rs
@@ -247,7 +247,7 @@ static LAST_STATIC_FUNCTION_ARG: Global<i64> = Global::default();

 #[derive(GodotClass)]
 #[class(init, base=Object)]
-struct Emitter {
+pub struct Emitter {
     _base: Base<Object>,
     #[cfg(since_api = "4.2")]
     last_received_int: i64,
diff --git a/itest/rust/src/builtin_tests/containers/variant_test.rs b/itest/rust/src/builtin_tests/containers/variant_test.rs
index 89208048..33f7df09 100644
--- a/itest/rust/src/builtin_tests/containers/variant_test.rs
+++ b/itest/rust/src/builtin_tests/containers/variant_test.rs
@@ -7,6 +7,7 @@

 use std::cmp::Ordering;
 use std::fmt::Display;
+use crate::builtin_tests::containers::signal_test::Emitter;

 use godot::builtin::{
     array, dict, varray, Array, GString, NodePath, Signal, StringName, Variant, Vector2, Vector3,
@@ -28,6 +29,9 @@ const TEST_BASIS: Basis = Basis::from_rows(

 #[itest]
 fn variant_nil() {
+    let emitter = Emitter::new_alloc();
+    let mut sig = emitter.signals().signal_int();
+
     let variant = Variant::nil();
     assert!(variant.is_nil());

function `signal_int` is private

[ColinWttt]

This was fixed in the “bugfix/signal-visibility” branch, and the Godot class must also be marked as pub currently.

godot ={ git = "https://github.com/godot-rust/gdext" , branch="bugfix/signal-visibility"}

[Bromeon]

Note that my branch still needs some improvements and isn't ready as-is. See #1061 (comment)

[Bromeon]

@austin226 @ColinWttt if you have the chance, let me know what you think of #1075 🙂