Skip to content

Commit a64f224

Browse files
committed
Use nightly.link for artifact download -> removes the need for PAT
Fixes #14
1 parent 84fbe94 commit a64f224

File tree

3 files changed

+13
-29
lines changed

3 files changed

+13
-29
lines changed

.github/composite/godot/action.yml

Lines changed: 12 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ inputs:
1414
required: true
1515
description: "Filename of the Godot executable"
1616

17-
github-pat:
18-
required: true
19-
description: "GitHub PAT (personal access token) to download artifacts from other repos"
20-
2117
rust-toolchain:
2218
required: false
2319
default: 'stable'
@@ -34,36 +30,26 @@ runs:
3430
steps:
3531
- uses: actions/checkout@v3
3632

33+
# Replaces also backspaces on Windows, since they cause problems in Bash
34+
- name: "Store variable to Godot binary"
35+
run: |
36+
runnerDir=$(echo "${{ runner.temp }}" | sed "s!\\\\!/!")
37+
echo "RUNNER_DIR=$runnerDir" >> $GITHUB_ENV
38+
echo "GODOT4_BIN=$runnerDir/godot_bin/${{ inputs.binary-filename }}" >> $GITHUB_ENV
39+
shell: bash
40+
3741
# - name: "Check cache for installed Godot version"
3842
# id: "cache-godot"
3943
# uses: actions/cache@v3
4044
# with:
4145
# path: ${{ runner.temp }}/godot_bin
42-
# #key: godot-${{ runner.os }}-v${{ inputs.godot-ver }}
43-
# key: ${{ inputs.artifact-name }}
46+
# key: ${{ inputs.artifact-name }}-v${{ inputs.godot-ver }}
4447

4548
- name: "Download Godot artifact"
4649
# if: steps.cache-godot.outputs.cache-hit != 'true'
47-
# https://github.com/dawidd6/action-download-artifact
48-
uses: dawidd6/action-download-artifact@v2
49-
with:
50-
# Downloads and unzips the artifact with {name} of the latest run of specified {workflow}
51-
path: ${{ runner.temp }}/godot_bin
52-
github_token: ${{ inputs.github-pat }}
53-
repo: Bromeon/godot4-nightly
54-
branch: master
55-
workflow: compile-godot.yml
56-
workflow_conclusion: success
57-
name: ${{ inputs.artifact-name }}
58-
# Search for the last workflow run, which stored an artifact named as in `name` input
59-
search_artifacts: true
60-
61-
# Replaces also backspaces on Windows, since they cause problems in Bash
62-
- name: "Store variable to Godot binary"
6350
run: |
64-
runnerDir=$(echo "${{ runner.temp }}" | sed "s!\\\\!/!")
65-
echo "RUNNER_DIR=$runnerDir" >> $GITHUB_ENV
66-
echo "GODOT4_BIN=$runnerDir/godot_bin/${{ inputs.binary-filename }}" >> $GITHUB_ENV
51+
curl https://nightly.link/Bromeon/godot4-nightly/workflows/compile-godot/master/${{ inputs.artifact-name }}.zip -Lo artifact.zip
52+
unzip artifact.zip -d $RUNNER_DIR/godot_bin
6753
shell: bash
6854

6955
# The chmod seems still necessary, although applied before uploading artifact. Possibly modes are not preserved.
@@ -133,6 +119,7 @@ runs:
133119
shell: bash
134120

135121
- name: "Conclusion"
122+
if: always()
136123
run: |
137124
echo "Evaluate conclusion ($OUTCOME)"
138125
@@ -165,6 +152,4 @@ runs:
165152
exit 4
166153
;;
167154
esac
168-
169155
shell: bash
170-
if: always()

.github/external-config/licenserc.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ header:
1414
- '.github/**/*.yml'
1515

1616
paths-ignore:
17-
- 'demo-project'
17+
- 'examples'
1818

1919
comment: on-failure
2020

.github/workflows/minimal-ci.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,6 @@ jobs:
9999
with:
100100
artifact-name: godot-${{ matrix.name }}
101101
binary-filename: ${{ matrix.godot-binary }}
102-
github-pat: ${{ secrets.ARTIFACT_DOWNLOADER_PAT }}
103102
#godot_ver: ${{ matrix.godot }}
104103

105104
license-guard:

0 commit comments

Comments
 (0)