From 3bac1c5b42d78b410a1382c75f47d4c1cefc0934 Mon Sep 17 00:00:00 2001 From: HesterG Date: Tue, 7 Mar 2023 14:52:01 +0800 Subject: [PATCH 1/2] fix adding of empty class name --- web_src/js/svg.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/web_src/js/svg.js b/web_src/js/svg.js index 2132ad312037c..53483c575d0a1 100644 --- a/web_src/js/svg.js +++ b/web_src/js/svg.js @@ -80,7 +80,8 @@ export function svg(name, size = 16, className = '') { const svgNode = document.firstChild; if (size !== 16) svgNode.setAttribute('width', String(size)); if (size !== 16) svgNode.setAttribute('height', String(size)); - if (className) svgNode.classList.add(...className.split(/\s+/)); + // filter array to remove empty string + if (className) svgNode.classList.add(...className.split(/\s+/).filter(item => item)); return serializer.serializeToString(svgNode); } From 31a4a94c81ea17c9f81049d2ac5fb9409689c167 Mon Sep 17 00:00:00 2001 From: HesterG Date: Tue, 7 Mar 2023 15:06:43 +0800 Subject: [PATCH 2/2] fix lint --- web_src/js/svg.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web_src/js/svg.js b/web_src/js/svg.js index 53483c575d0a1..6476f16bfb3eb 100644 --- a/web_src/js/svg.js +++ b/web_src/js/svg.js @@ -81,7 +81,7 @@ export function svg(name, size = 16, className = '') { if (size !== 16) svgNode.setAttribute('width', String(size)); if (size !== 16) svgNode.setAttribute('height', String(size)); // filter array to remove empty string - if (className) svgNode.classList.add(...className.split(/\s+/).filter(item => item)); + if (className) svgNode.classList.add(...className.split(/\s+/).filter(Boolean)); return serializer.serializeToString(svgNode); }