Skip to content

OAuth-created Accounts cannot be unlinked #5032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
coolaj86 opened this issue Oct 7, 2018 · 2 comments
Closed

OAuth-created Accounts cannot be unlinked #5032

coolaj86 opened this issue Oct 7, 2018 · 2 comments
Labels
issue/stale type/enhancement An improvement of existing functionality

Comments

@coolaj86
Copy link
Contributor

coolaj86 commented Oct 7, 2018

While reviewing the code I found that OAuth-created accounts are treated differently than oauth-linked accounts.

Currently under Manage account links (/user/settings/security) they cannot be unlinked from the oauth provider that created them, despite having their own username and email address.

I believe this is the desired behavior when ALLOW_ONLY_EXTERNAL_REGISTRATION is set, but should probably not be the behavior generally.

I'll include the fix in with another related PR, but I wanted to document it separately here for now.

@lafriks lafriks added the type/enhancement An improvement of existing functionality label Oct 7, 2018
@stale
Copy link

stale bot commented Jan 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 7, 2019
@stale
Copy link

stale bot commented Feb 22, 2019

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this as completed Feb 22, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/stale type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants