No notifications on commits in pull requests

[amix307]

Description

After upgrading to Gitea 1.23.5 and later to 1.23.7, notifications about new commits in pull requests have stopped being delivered. This affects users who should receive them via email and are listed in CODEOWNERS

Problem Description:
Previously, when a new commit was pushed to a pull request, notifications were correctly sent to:

• All reviewers/approvers
• Users listed in the CODEOWNERS file

Now, after the upgrade:

• These users no longer receive any notification about the new commits
• Other notifications (e.g. about review requests, PR creation) still work as expected
• There were no changes in SMTP settings or CODEOWNERS structure

What I Checked:

• Verified SMTP settings
• Confirmed users are in CODEOWNERS
• Verified users have not disabled notifications in their settings
• Notifications for other events still function
• Problem appeared right after upgrading from 1.23.4 to 1.23.5 and persists in 1.23.7
• No errors found in logs related to email sending on PR commit updates

Expected Behavior:

Users who are approvers or listed in CODEOWNERS should receive email notifications when new commits are pushed to a PR.

Gitea Version

1.23.7

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

CentOS 9-Stream

How are you running Gitea?

systemd

Database

PostgreSQL

[wxiaoguang]

@lunny

-> Pull request updates will also trigger code owners review requests (#33744) #34045

And there is a new change in 1.23-nightly : Fix wrong review requests when updating the pull request (#34286) #34304

I am not sure whether it "fixes" the problem. Maybe you could try 1.23-nightly:

• https://dl.gitea.com/gitea/1.23-nightly/
• https://hub.docker.com/r/gitea/gitea/tags?name=1.23-nightly

[amix307]

@wxiaoguang I’ll test this on the staging instance first, though the load there is minimal. I plan to deploy the fix to production in the next release.

Regarding the issue with reviewers being reset and reassigned from CODEOWNERS during PR changes, I’ve also noticed inconsistent notifications—sometimes certain reviewers receive them while others don’t. Unfortunately, this isn’t clearly reflected in the logs, making it difficult to trace.