Fix loading LFS_JWT_SECRET from wrong section (#26109)

wolfogre · web-flow · commit 862f748b2b33 · 2023-07-25T05:06:31.000Z
Regression of #25408. `LFS_JWT_SECRET_URI` and `LFS_JWT_SECRET` are under the `server` section, not `lfs`. So each time gitea restarts, it resets `LFS_JWT_SECRET`. <img width="1378" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/527ec9b9-eea2-4334-a274-6d1471456edd">
diff --git a/modules/setting/lfs.go b/modules/setting/lfs.go
@@ -53,7 +53,7 @@ func loadLFSFrom(rootCfg ConfigProvider) error {
 		return nil
 	}
 
-	LFS.JWTSecretBase64 = loadSecret(rootCfg.Section("lfs"), "LFS_JWT_SECRET_URI", "LFS_JWT_SECRET")
+	LFS.JWTSecretBase64 = loadSecret(rootCfg.Section("server"), "LFS_JWT_SECRET_URI", "LFS_JWT_SECRET")
 
 	LFS.JWTSecretBytes = make([]byte, 32)
 	n, err := base64.RawURLEncoding.Decode(LFS.JWTSecretBytes, []byte(LFS.JWTSecretBase64))

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ func loadLFSFrom(rootCfg ConfigProvider) error {`
`53`	`53`	`return nil`
`54`	`54`	`}`
`55`	`55`
`56`		`- LFS.JWTSecretBase64 = loadSecret(rootCfg.Section("lfs"), "LFS_JWT_SECRET_URI", "LFS_JWT_SECRET")`
	`56`	`+ LFS.JWTSecretBase64 = loadSecret(rootCfg.Section("server"), "LFS_JWT_SECRET_URI", "LFS_JWT_SECRET")`
`57`	`57`
`58`	`58`	`LFS.JWTSecretBytes = make([]byte, 32)`
`59`	`59`	`n, err := base64.RawURLEncoding.Decode(LFS.JWTSecretBytes, []byte(LFS.JWTSecretBase64))`