BeforeSourcePath should point to base commit (#18880)

jpraet · web-flow · commit 6f21a94d1885 · 2022-02-25T14:45:20.000+08:00
diff --git a/routers/web/repo/compare.go b/routers/web/repo/compare.go
@@ -77,8 +77,8 @@ func setPathsCompareContext(ctx *context.Context, base, head *git.Commit, headOw
 	ctx.Data["SourcePath"] = SourceCommitURL(headOwner, headName, head)
 	ctx.Data["RawPath"] = RawCommitURL(headOwner, headName, head)
 	if base != nil {
-		ctx.Data["BeforeSourcePath"] = SourceCommitURL(headOwner, headName, head)
-		ctx.Data["BeforeRawPath"] = RawCommitURL(headOwner, headName, head)
+		ctx.Data["BeforeSourcePath"] = SourceCommitURL(headOwner, headName, base)
+		ctx.Data["BeforeRawPath"] = RawCommitURL(headOwner, headName, base)
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -77,8 +77,8 @@ func setPathsCompareContext(ctx context.Context, base, head git.Commit, headOw`
`77`	`77`	`ctx.Data["SourcePath"] = SourceCommitURL(headOwner, headName, head)`
`78`	`78`	`ctx.Data["RawPath"] = RawCommitURL(headOwner, headName, head)`
`79`	`79`	`if base != nil {`
`80`		`- ctx.Data["BeforeSourcePath"] = SourceCommitURL(headOwner, headName, head)`
`81`		`- ctx.Data["BeforeRawPath"] = RawCommitURL(headOwner, headName, head)`
	`80`	`+ ctx.Data["BeforeSourcePath"] = SourceCommitURL(headOwner, headName, base)`
	`81`	`+ ctx.Data["BeforeRawPath"] = RawCommitURL(headOwner, headName, base)`
`82`	`82`	`}`
`83`	`83`	`}`
`84`	`84`