Fix broken webhooks (#29690)

lunny · web-flow · commit 6e8762f962c5 · 2024-03-10T01:32:48.000Z
Fix #29689
diff --git a/services/webhook/payloader.go b/services/webhook/payloader.go
@@ -94,7 +94,12 @@ func newJSONRequest[T any](pc payloadConvertor[T], w *webhook_model.Webhook, t *
 		return nil, nil, err
 	}
 
-	req, err := http.NewRequest(w.HTTPMethod, w.URL, bytes.NewReader(body))
+	method := w.HTTPMethod
+	if method == "" {
+		method = http.MethodPost
+	}
+
+	req, err := http.NewRequest(method, w.URL, bytes.NewReader(body))
 	if err != nil {
 		return nil, nil, err
 	}

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,12 @@ func newJSONRequest[T any](pc payloadConvertor[T], w webhook_model.Webhook, t `
`94`	`94`	`return nil, nil, err`
`95`	`95`	`}`
`96`	`96`
`97`		`- req, err := http.NewRequest(w.HTTPMethod, w.URL, bytes.NewReader(body))`
	`97`	`+ method := w.HTTPMethod`
	`98`	`+ if method == "" {`
	`99`	`+ method = http.MethodPost`
	`100`	`+ }`
	`101`	`+`
	`102`	`+ req, err := http.NewRequest(method, w.URL, bytes.NewReader(body))`
`98`	`103`	`if err != nil {`
`99`	`104`	`return nil, nil, err`
`100`	`105`	`}`