fix regression from #16075 (#18260)

noerw · 6543 · web-flow · commit 696521b33bb3 · 2022-01-14T00:50:43.000+08:00
we don't want reviews to count towards comments, as this needs changes
in other components as well (eg repo stats cron job, etc).

Co-authored-by: 6543 &lt;6543@obermui.de&gt;
diff --git a/models/issue_comment.go b/models/issue_comment.go
@@ -835,13 +835,12 @@ func updateCommentInfos(ctx context.Context, opts *CreateCommentOptions, comment
 			}
 		}
 		fallthrough
-	case CommentTypeReview:
-		fallthrough
 	case CommentTypeComment:
 		if _, err = e.Exec("UPDATE `issue` SET num_comments=num_comments+1 WHERE id=?", opts.Issue.ID); err != nil {
 			return err
 		}
-
+		fallthrough
+	case CommentTypeReview:
 		// Check attachments
 		attachments, err := repo_model.GetAttachmentsByUUIDs(ctx, opts.Attachments)
 		if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -835,13 +835,12 @@ func updateCommentInfos(ctx context.Context, opts *CreateCommentOptions, comment`
`835`	`835`	`}`
`836`	`836`	`}`
`837`	`837`	`fallthrough`
`838`		`- case CommentTypeReview:`
`839`		`- fallthrough`
`840`	`838`	`case CommentTypeComment:`
`841`	`839`	if _, err = e.Exec("UPDATE `issue` SET num_comments=num_comments+1 WHERE id=?", opts.Issue.ID); err != nil {
`842`	`840`	`return err`
`843`	`841`	`}`
`844`		`-`
	`842`	`+ fallthrough`
	`843`	`+ case CommentTypeReview:`
`845`	`844`	`// Check attachments`
`846`	`845`	`attachments, err := repo_model.GetAttachmentsByUUIDs(ctx, opts.Attachments)`
`847`	`846`	`if err != nil {`