Skip to content

Commit 5398a44

Browse files
Loïc Dacharyrealaravinth
Loïc Dachary
authored andcommitted
tests: set milestone.deadline_unix in fixtures
The value of deadline_unix must be set to 253370764800 (i.e. 9999-01-01) in fixtures, otherwise it will be inserted as null which leads to unexpected errors. For instance, DumpRepository will store a null deadline_unix as 0 (i.e. 1970-01-01) and RestoreRepository will change it to 9999-01-01. Signed-off-by: Loïc Dachary <[email protected]>
1 parent 2fded87 commit 5398a44

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

models/fixtures/milestone.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
is_closed: false
77
num_issues: 1
88
num_closed_issues: 0
9+
deadline_unix: 253370764800
910

1011
-
1112
id: 2
@@ -15,6 +16,7 @@
1516
is_closed: false
1617
num_issues: 0
1718
num_closed_issues: 0
19+
deadline_unix: 253370764800
1820

1921
-
2022
id: 3
@@ -24,6 +26,7 @@
2426
is_closed: true
2527
num_issues: 1
2628
num_closed_issues: 0
29+
deadline_unix: 253370764800
2730

2831
-
2932
id: 4
@@ -33,6 +36,7 @@
3336
is_closed: false
3437
num_issues: 0
3538
num_closed_issues: 0
39+
deadline_unix: 253370764800
3640

3741
-
3842
id: 5
@@ -42,3 +46,4 @@
4246
is_closed: false
4347
num_issues: 0
4448
num_closed_issues: 0
49+
deadline_unix: 253370764800

services/migrations/gitea_uploader.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,9 @@ func (g *GiteaLocalUploader) CreateMilestones(milestones ...*base.Milestone) err
165165
if milestone.Deadline != nil {
166166
deadline = timeutil.TimeStamp(milestone.Deadline.Unix())
167167
}
168+
if deadline == 0 {
169+
deadline = timeutil.TimeStamp(time.Date(9999, 1, 1, 0, 0, 0, 0, setting.DefaultUILocation).Unix())
170+
}
168171

169172
if milestone.Created.IsZero() {
170173
if milestone.Updated != nil {

0 commit comments

Comments
 (0)