update util.CleanPath usage, drop useless error const

Author: fuxiaohei

modules/storage/local.go

@@ -130,10 +130,7 @@ func (l *LocalStorage) URL(path, name string) (*url.URL, error) {
 func (l *LocalStorage) IterateObjects(prefix string, fn func(path string, obj Object) error) error {
 	dir := l.dir
 	if prefix != "" {
-		dir = util.CleanPath(filepath.Join(l.dir, prefix))
-		if !strings.HasPrefix(dir, strings.TrimSuffix(l.dir, "/")) {
-			return ErrIllegalPath
-		}
+		dir = filepath.Join(l.dir, util.CleanPath(prefix))
 	}
 	return filepath.WalkDir(dir, func(path string, d os.DirEntry, err error) error {
 		if err != nil {

modules/storage/local_test.go

@@ -91,18 +91,4 @@ func TestLocalStorageIterator(t *testing.T) {
 		assert.NoError(t, err)
 		assert.Equal(t, count, len(expected))
 	}
-
-	// illegal dir
-	illegalDirs := []string{
-		"../a",
-		"../../etc/hosts",
-		"../a/../b",
-	}
-	for _, dir := range illegalDirs {
-		err = l.IterateObjects(dir, func(path string, f Object) error {
-			defer f.Close()
-			return nil
-		})
-		assert.Error(t, err, ErrIllegalPath)
-	}
 }

modules/storage/storage.go

@@ -18,9 +18,6 @@ import (
 // ErrURLNotSupported represents url is not supported
 var ErrURLNotSupported = errors.New("url method not supported")
 
-// ErrIllegalPath represents path is illegal
-var ErrIllegalPath = errors.New("illegal path")
-
 // ErrInvalidConfiguration is called when there is invalid configuration for a storage
 type ErrInvalidConfiguration struct {
 	cfg interface{}