Apply suggestion from code-Review

Co-authored-by: silverwind <[email protected]>
Co-authored-by: Gary Kim <[email protected]>

Author: 3 people

models/repo_permission.go

@@ -250,7 +250,7 @@ func getUserRepoPermission(ctx context.Context, repo *repo_model.Repository, use
 			perm.UnitsMode = nil
 			return
 		}
-		// Check if the team has acces to private issues.
+		// Check if the team has access to private issues.
 		if team.CanSeePrivateIssues {
 			perm.SeePrivateIssue = true
 		}

options/locale/locale_en-US.ini

@@ -1413,9 +1413,9 @@ issues.content_history.delete_from_history_confirm = Delete from history?
 issues.content_history.options = Options
 issues.confidential = Confidential
 issues.confidential.off = Make issue public
-issues.confidential.off_popup = By clicking this button, you will make this issue and comments public to everyone who can read this repo.
+issues.confidential.off_popup = By clicking this button, this issue will be visible to everyone with read access to this repositry.
 issues.confidential.on = Make issue confidential
-issues.confidential.on_popup = By turning on the confidential mode, only the poster, repo admins and team members who have "Access private issues" permission will be able to access this issue.
+issues.confidential.on_popup = By turning on the confidential mode, only the poster, repository administrators and team members who have "Access private issues" permission will be able to access this issue.
 issues.confidential.title_bar = This issue is confidential
 issues.confidential.warning = This issue is marked as confidential, your comment won't be visible to the public.
 

templates/repo/issue/view_content/sidebar.tmpl

@@ -304,14 +304,14 @@
 
 		{{if and (or (.IsRepoAdmin) (.IsIssuePoster)) (not .Issue.IsPull)}}
 		<div class="ui divider"></div>
-		<div class="ui">
+		<div>
 			<span class="text"><strong>{{.i18n.Tr "repo.issues.confidential"}}</strong></span>
 			<div class="mt-3">
 				<form method="POST" action="{{.Issue.Link}}/private">
 					<input type="hidden" name="is_confidential" value="{{if .Issue.IsPrivate}}false{{else}}true{{end}}" />
 					{{$.CsrfTokenHtml}}
 					<label class="tooltip" data-content="{{if .Issue.IsPrivate}}{{.i18n.Tr "repo.issues.confidential.off_popup"}}{{else}}{{.i18n.Tr "repo.issues.confidential.on_popup"}}{{end}}">
-					<button data-tooltip="hi" class="fluid ui button df jc">
+					<button class="fluid ui button df jc">
 						{{if .Issue.IsPrivate}}
 							{{svg "octicon-eye-closed" 16 "mr-3 text orange"}}
 							{{.i18n.Tr "repo.issues.confidential.off"}}

templates/shared/issuelist.tmpl

@@ -33,7 +33,6 @@
 							{{svg "octicon-issue-opened" 16 "text green"}}
 						{{end}}
 					{{end}}
-
 				</div>
 			</div>
 			<div class="issue-item-main f1 fc df">