Skip to content

Keyboard layout #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
zephylac opened this issue Dec 21, 2018 · 3 comments
Closed
1 of 2 tasks

Keyboard layout #53

zephylac opened this issue Dec 21, 2018 · 3 comments
Assignees
Labels
bug Something isn't working embedder Issue concerns the embedder package Linux Specifically concerns Linux MacOS Specifically concerns MacOS Windows Specifically concerns Windows

Comments

@zephylac
Copy link
Collaborator

Flutter version

Flutter 1.0.0 • channel beta • https://github.com/flutter/flutter.git
Framework • revision 5391447fae (2 weeks ago) • 2018-11-29 19:41:26 -0800
Engine • revision 7375a0f414
Tools • Dart 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)

Does the prebuilt and portable version works ?

Yes

Download Link
  • Yes
  • No

Steps to Reproduce

glfw.SetKeyCallback doesn't support keyboard layout. It only support US layout. Documentation.
Whereas glfwSetCharCallbackwill support layout
This has for consequence to miss understand event but since we get actual key value from glfwSetCharCallback you will write what your keyboard is supposed to write.

For example if you have an AZERTY keyboard. When pressing A, glfw.keyQ event will be recorded but glfwCharCallback will know you are under another layout and will write A to your screen.
This problem breaks shortcuts under all operating system.

@zephylac zephylac self-assigned this Dec 21, 2018
@zephylac zephylac added embedder Issue concerns the embedder package bug Something isn't working Windows Specifically concerns Windows Linux Specifically concerns Linux MacOS Specifically concerns MacOS labels Dec 21, 2018
@zephylac
Copy link
Collaborator Author

f3f4361

@pchampio
Copy link
Member

I reviewed your works!

@zephylac
Copy link
Collaborator Author

zephylac commented Jan 23, 2019

This is issue closed following pull request : #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working embedder Issue concerns the embedder package Linux Specifically concerns Linux MacOS Specifically concerns MacOS Windows Specifically concerns Windows
Development

No branches or pull requests

2 participants